Skip to content

features: update timely_vote_credits#1710

Merged
0x0ece merged 1 commit into
0x0ece/featuresfrom
0x0ece/features-2
May 3, 2024
Merged

features: update timely_vote_credits#1710
0x0ece merged 1 commit into
0x0ece/featuresfrom
0x0ece/features-2

Conversation

@0x0ece
Copy link
Copy Markdown
Contributor

@0x0ece 0x0ece commented May 2, 2024

Context: anza-xyz/agave#127

We need to update our test ledgers:

  • v18-small (fails at slot 2)
  • helloworld (fails at slot 101)

@0x0ece 0x0ece force-pushed the 0x0ece/features-2 branch from 7f97c5c to a2a9476 Compare May 2, 2024 17:57
@0x0ece 0x0ece force-pushed the 0x0ece/features branch from 3dfa483 to e9b572f Compare May 2, 2024 17:57
@0x0ece 0x0ece force-pushed the 0x0ece/features-2 branch from a2a9476 to 22ded4e Compare May 2, 2024 21:17
@ripatel-fd
Copy link
Copy Markdown
Contributor

I guess we'll have to regenerate the test ledger. Very annoying, thanks Anza.

Copy link
Copy Markdown
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@topointon-jump
Copy link
Copy Markdown
Contributor

I will make v18-small-2 with the new public keys for the feature, and we can remove helloworld as it's a subset of the other ledger tests.

@0x0ece 0x0ece force-pushed the 0x0ece/features branch 2 times, most recently from 137e2b9 to 70c671c Compare May 3, 2024 15:16
@0x0ece 0x0ece force-pushed the 0x0ece/features-2 branch from 22ded4e to eb4dd17 Compare May 3, 2024 15:23
@0x0ece 0x0ece merged commit d61516d into 0x0ece/features May 3, 2024
@0x0ece 0x0ece deleted the 0x0ece/features-2 branch May 3, 2024 15:32
@0x0ece
Copy link
Copy Markdown
Contributor Author

0x0ece commented May 3, 2024

Merged into the other PR, to keep everything in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants