Skip to content

v1.18: Update maximum credits awarded per vote from 8 to 16 (backport of #127)#138

Closed
mergify[bot] wants to merge 1 commit into
v1.18from
mergify/bp/v1.18/pr-127
Closed

v1.18: Update maximum credits awarded per vote from 8 to 16 (backport of #127)#138
mergify[bot] wants to merge 1 commit into
v1.18from
mergify/bp/v1.18/pr-127

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Mar 7, 2024

This is an automatic backport of pull request #127 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

This reduces the maximum penalty for voting after the grace period by
roughly 50%.  This new value was derived from looking at the effects
that TVC at max credits 8 would have for recent epochs (500+) and
noting that the effect was a bit extreme, up to and exceeding 10%
"bonus" for faster voters.  This change reduces that maximum bonus by
roughly half.

In addition, the TVC feature key has been changed.

(cherry picked from commit 940bd30)
@mergify mergify Bot added the feature-gate label Mar 7, 2024
@steviez
Copy link
Copy Markdown

steviez commented Mar 14, 2024

Aside from this BP - all of the logic is in both v1.18 and v1.17 correct ? Ie, assuming governance vote goes through, we'd be able to activate this feature while mnb is running v1.17 ?

@AshwinSekar
Copy link
Copy Markdown

yes that's correct, technically we could bp this to 1.17 as well. since the plan is to activate this on testnet first (which is on 1.18), it makes sense to respect the feature ordering and wait for mainnet to be on 1.18 when we activate.

@t-nelson
Copy link
Copy Markdown

don't forget to update the activation schedule!

@AshwinSekar
Copy link
Copy Markdown

don't forget to update the activation schedule!

was already updated 🙃

@mergify mergify Bot deleted the mergify/bp/v1.18/pr-127 branch March 19, 2024 22:04
OliverNChalk pushed a commit to OliverNChalk/agave that referenced this pull request Nov 11, 2025
Most of the document is already formatted to be 80 characters wide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants