Further update Granite to be compatible with Crystal 0.25

[robacarp]

The latest granite tag produces this when attempting to build amber projects which used the scaffold generator:

instantiating 'PostCommentController#create()'
in src/controllers/post_comment_controller.cr:22: no overload matches 'PostComment.new' with type Hash(String, String | Nil)
Overloads are:
 - Granite::Base.new(args : Hash(Symbol | String, String | JSON::Any))
 - Granite::Base.new(**args : Object)
 - Granite::Base.new()

    post_comment = PostComment.new(post_comment_params.validate!)

In trying to get the amber project compatible with crystal 0.25, I'd like to change this to JSON::Any::Type, which allows the generated code to compile.

[eliasjpr]

I have asked in the Crystal channel about JSON::Any and JSON::Any::Type I think the later makes more sense to keep things compatible. Not sure waiting for a response from the Crystal channel

[eliasjpr]

I think we should be using JSON::Any::Type everwhere we had JSON::Type since both points to a union type

[robacarp]

I’d discourage tagging after this is merged until it’s known that no other changes need to be made to Granite to make amber compatible

[eliasjpr]

To be safe we should probably use def initialize(args : Hash(Symbol | String, JSON::Any | JSON::Any::Type)) this will support the new way and the previous way

[eliasjpr]

Lets define a initialize overload, I think it would be better

def initialize(args : Hash(Symbol | String, JSON::Any::Type))
  new(JSON::Any.new raw(args))
end

def initialize(args : Hash(Symbol | String, JSON::Any))
end

[eliasjpr]

👍

[robacarp]

cc @Blacksmoke16

[Blacksmoke16]

neat, i like that better.

[eliasjpr]

👍🏻

[eliasjpr]

Sweet this is now passing