p_qps and b_qps are not intuitive in monitoring curve of dashboard. Let's make it a little bit more intuitive in Chinese #398

Arlmls · 2019-01-08T13:13:39Z

Describe what this PR does / why we need it

p_qps and b_qps are not intuitive in monitoring curve of dashboard.
Let's make it a little bit more intuitive in Chinese

Does this pull request fix one issue?

Fixes #394

Describe how you did it

1.The header and column are updated to Chinese

Describe how to verify it

Packaging operation，Observe effect

Special notes for reviews

no

) * Use named thread factory with all thread pools for identification Signed-off-by: Eric Zhao <[email protected]>

Signed-off-by: Eric Zhao <[email protected]>

- Sentinel should not send heartbeat to dashboard until the runtime port has been settled down Signed-off-by: Eric Zhao <[email protected]>

Signed-off-by: Eric Zhao <[email protected]>

Modify MethodUtil#methodNameMap and CtSph#chainMap: add `volatile` to keep in line with others

- Code refinement - Add test cases Signed-off-by: Eric Zhao <[email protected]>

…ddresses Signed-off-by: Eric Zhao <[email protected]>

- Update document for Dubbo demo - Update document for extensions Signed-off-by: Eric Zhao <[email protected]>

- Update test cases and demo Signed-off-by: Eric Zhao <[email protected]>

Signed-off-by: Eric Zhao <[email protected]>

- Update javadoc and document Signed-off-by: Eric Zhao <[email protected]>

Signed-off-by: Eric Zhao <[email protected]>

- This has been replaced with Spring Cloud Alibaba Signed-off-by: Eric Zhao <[email protected]>

* Optimize for leap array - Fix a bug: old position is not cleaned when inserting into a new (empty) position - Reuse buckets for optimization - The strategy is now changed: deprecated buckets will not be reset until newer time triggered. LeapArray is responsible for filtering the deprecated buckets (e.g. in `list` or `values`) - Update test cases Signed-off-by: Eric Zhao <[email protected]>

Signed-off-by: Eric Zhao <[email protected]>

- This bug can cause init failure of `AppNameUtil` Signed-off-by: Eric Zhao <[email protected]>

- Add Maven Central badge Signed-off-by: Eric Zhao <[email protected]>

Related to alibaba#57

Signed-off-by: Eric Zhao <[email protected]>

- Enlarge retry timeout to 2s by default - Improve remote address representation Signed-off-by: Eric Zhao <[email protected]>

- Also add top-K frequent parameter statistic support Signed-off-by: Eric Zhao <[email protected]>

- Add cluster token server management controller and service for app - Other enhancements and fixes Signed-off-by: Eric Zhao <[email protected]>

- Add cluster server list and assign page and client list page (for a specific app) Signed-off-by: Eric Zhao <[email protected]>

Signed-off-by: Eric Zhao <[email protected]>

…and fix edit rule issue when cancel (alibaba#370) - Make fallbackToLocalWhenFail of cluster rules configurable in dashboard - Fix edit rule when hit cancel button (object share problem solved by deep copy) - Add metric table td header's title for friendly prompt info

…ashboard (alibaba#376)

Signed-off-by: Eric Zhao <[email protected]>

CLAassistant · 2019-01-08T13:13:46Z

All committers have signed the CLA.

sczyh30 · 2019-01-08T14:12:31Z

Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email.

感谢贡献，请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并确认一下 CLA。

Arlmls · 2019-01-08T16:34:26Z

Already modified.If there are questions,I hope to teach,because this is the first submission.

sczyh30 · 2019-01-09T06:25:09Z

rebase 的时候可能出了些问题？提交线不太对，出现了冲突。可否重新基于当前 master 分支新建分支进行变更？

Arlmls · 2019-01-09T08:29:15Z

rebase 的时候可能出了些问题？提交线不太对，出现了冲突。可否重新基于当前 master 分支新建分支进行变更？

merged！Please review

codecov-io · 2019-01-09T08:30:46Z

Codecov Report

Merging #398 into master will decrease coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #398      +/-   ##
============================================
- Coverage      37.5%   37.05%   -0.45%     
+ Complexity      947      940       -7     
============================================
  Files           224      224              
  Lines          7221     7221              
  Branches        984      984              
============================================
- Hits           2708     2676      -32     
- Misses         4171     4207      +36     
+ Partials        342      338       -4

Impacted Files	Coverage Δ	Complexity Δ
...a/csp/sentinel/slots/statistic/base/Striped64.java	`26.04% <0%> (-23.96%)`	`5% <0%> (-2%)`
...a/csp/sentinel/slots/statistic/base/LongAdder.java	`17.02% <0%> (-14.9%)`	`4% <0%> (-4%)`
...a/csp/sentinel/slots/statistic/base/LeapArray.java	`65.82% <0%> (-2.54%)`	`23% <0%> (-1%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c70c94...cd07109. Read the comment docs.

sczyh30

LGTM

sczyh30 · 2019-01-09T09:16:45Z

Nice, thanks for contributing!

…ty_issue [ISSUE alibaba#395]Resolve compatibility issues and keep consistent with the old API

sczyh30 and others added 30 commits July 30, 2018 18:10

Fixes alibaba#9: Use named thread factory for identification (alibaba#10

94f468a

) * Use named thread factory with all thread pools for identification Signed-off-by: Eric Zhao <[email protected]>

Add log when initializing Sentinel Dubbo filters

19fdd45

Signed-off-by: Eric Zhao <[email protected]>

Fixes alibaba#13: Fix search filter in Sentinel Dashboard sidebar

7f075f7

Signed-off-by: Eric Zhao <[email protected]>

Refine AppNameUtil

d5ec3e4

Fixes alibaba#14: Apply Alibaba Java Coding Guidelines

9bd2a62

Signed-off-by: Eric Zhao <[email protected]>

Update README.md

c35f72a

Refine Degrade rule checking.

2be43e7

Fixes alibaba#20: Fix runtime port and heartbeat sending logic

fc6ee7a

- Sentinel should not send heartbeat to dashboard until the runtime port has been settled down Signed-off-by: Eric Zhao <[email protected]>

Fixes test cases for degrade regarding the new strategy

4a3d489

Signed-off-by: Eric Zhao <[email protected]>

Add volatile to methodNameMap and chainMap (alibaba#34)

e724913

Modify MethodUtil#methodNameMap and CtSph#chainMap: add `volatile` to keep in line with others

Add ZooKeeper data source for Sentinel (alibaba#33)

e9c1ed4

Update ZooKeeper data source integration

df8cd09

- Code refinement - Add test cases Signed-off-by: Eric Zhao <[email protected]>

Fixes alibaba#38: Enhance error handling when parsing bad dashboard a…

80cd533

…ddresses Signed-off-by: Eric Zhao <[email protected]>

Update documents

3a37015

- Update document for Dubbo demo - Update document for extensions Signed-off-by: Eric Zhao <[email protected]>

Add default fallback support for Dubbo

e34d2cb

- Update test cases and demo Signed-off-by: Eric Zhao <[email protected]>

Add Sentinel annotation definition and aspectj extension

b856cfc

Signed-off-by: Eric Zhao <[email protected]>

Add demo for Sentinel Annotation AspectJ with Spring AOP

be9ba32

Signed-off-by: Eric Zhao <[email protected]>

Add support for shared block handler

919ba5e

- Update javadoc and document Signed-off-by: Eric Zhao <[email protected]>

Set SystemRule's threshold to zero is allowed.

491ddfb

Fix pom.xml error of sentinel-transport

e65d490

Signed-off-by: Eric Zhao <[email protected]>

Remove sentinel-spring-boot-starter module

45cc1e8

- This has been replaced with Spring Cloud Alibaba Signed-off-by: Eric Zhao <[email protected]>

Add Apollo data source extension (alibaba#46)

0dee4de

Bump version to 0.1.1

ecca8b6

Signed-off-by: Eric Zhao <[email protected]>

Bump version to 0.2.0-SNAPSHOT

7c59205

Signed-off-by: Eric Zhao <[email protected]>

Fixes alibaba#51, use js type–converting comparisons.

b5281ec

Fixes alibaba#52: Error file separator regex in Windows environment

d035f52

- This bug can cause init failure of `AppNameUtil` Signed-off-by: Eric Zhao <[email protected]>

Update documents

ceddc31

- Add Maven Central badge Signed-off-by: Eric Zhao <[email protected]>

Fix url for Maven Central Badge

5cdb1e4

Related to alibaba#57

Fix typo in rule constants and add authority rule demo

f9fb8cd

Signed-off-by: Eric Zhao <[email protected]>

sczyh30 and others added 12 commits January 4, 2019 14:36

Polish cluster token server handler related logic

d78b682

- Enlarge retry timeout to 2s by default - Improve remote address representation Signed-off-by: Eric Zhao <[email protected]>

Add basic monitoring command API for cluster token server

5b75dcc

- Also add top-K frequent parameter statistic support Signed-off-by: Eric Zhao <[email protected]>

Polish Sentinel dashboard backend for cluster flow control enhancement

e69b88d

- Add cluster token server management controller and service for app - Other enhancements and fixes Signed-off-by: Eric Zhao <[email protected]>

Polish Sentinel dashboard frontend for cluster flow control enhancement

7121c41

- Add cluster server list and assign page and client list page (for a specific app) Signed-off-by: Eric Zhao <[email protected]>

Bump version to 1.4.1

77a29d1

Signed-off-by: Eric Zhao <[email protected]>

Bump version to 1.4.2-SNAPSHOT

d06e07d

Signed-off-by: Eric Zhao <[email protected]>

doc: add blog with Sentinel in action (alibaba#392)

55ee45b

dashboard: add healthCount/total information in sidebar of Sentinel d…

5f62e15

…ashboard (alibaba#376)

dashboard: structure rearrangement and polish related code

7ddb326

Signed-off-by: Eric Zhao <[email protected]>

Copy to modify,p_qps->通过的QPS b_qps->拒绝的QPS

c56af94

M 表图例

d3334f2

Arlmls force-pushed the master branch from 288d21f to d3334f2 Compare January 8, 2019 16:27

sczyh30 requested a review from CarpenterLee January 9, 2019 06:25

sczyh30 added the to-review To review label Jan 9, 2019

sczyh30 removed the request for review from CarpenterLee January 9, 2019 06:25

Arlmls added 2 commits January 9, 2019 16:11

Merge remote-tracking branch 'upstream/master'

da0c750

Merge branch 'master' of https://github.com/Arlmls/Sentinel

cd07109

sczyh30 approved these changes Jan 9, 2019

View reviewed changes

sczyh30 merged commit 6dfe8e3 into alibaba:master Jan 9, 2019

sczyh30 removed the to-review To review label Jan 9, 2019

sentinel-bot mentioned this pull request Jan 11, 2019

[WeeklyReport] Weekly report for Sentinel 2019-1-4 to 2019-1-11 #407

Closed

CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021

Merge pull request alibaba#398 from duhengforever/develop_compatibili…

cdf4042

…ty_issue [ISSUE alibaba#395]Resolve compatibility issues and keep consistent with the old API

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

p_qps and b_qps are not intuitive in monitoring curve of dashboard. Let's make it a little bit more intuitive in Chinese #398

p_qps and b_qps are not intuitive in monitoring curve of dashboard. Let's make it a little bit more intuitive in Chinese #398

Arlmls commented Jan 8, 2019

CLAassistant commented Jan 8, 2019 •

edited

Loading

sczyh30 commented Jan 8, 2019

Arlmls commented Jan 8, 2019

sczyh30 commented Jan 9, 2019

Arlmls commented Jan 9, 2019

codecov-io commented Jan 9, 2019

sczyh30 left a comment

sczyh30 commented Jan 9, 2019

p_qps and b_qps are not intuitive in monitoring curve of dashboard. Let's make it a little bit more intuitive in Chinese #398

p_qps and b_qps are not intuitive in monitoring curve of dashboard. Let's make it a little bit more intuitive in Chinese #398

Conversation

Arlmls commented Jan 8, 2019

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

CLAassistant commented Jan 8, 2019 • edited Loading

sczyh30 commented Jan 8, 2019

Arlmls commented Jan 8, 2019

sczyh30 commented Jan 9, 2019

Arlmls commented Jan 9, 2019

codecov-io commented Jan 9, 2019

Codecov Report

sczyh30 left a comment

Choose a reason for hiding this comment

sczyh30 commented Jan 9, 2019

CLAassistant commented Jan 8, 2019 •

edited

Loading