Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify MethodUtil#methodNameMap and CtSph#chainMap, add volatile. #34

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

manzhizhen
Copy link
Contributor

…p in line with

Describe what this PR does / why we need it

modify MethodUtil#methodNameMap and CtSph#chainMap, add volatile, keep in line with ContextUtil#contextNameNodeMap.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #34 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
- Coverage     46.54%   46.37%   -0.17%     
+ Complexity      544      541       -3     
============================================
  Files           105      105              
  Lines          3657     3657              
  Branches        519      519              
============================================
- Hits           1702     1696       -6     
- Misses         1751     1754       +3     
- Partials        204      207       +3
Impacted Files Coverage Δ Complexity Δ
...java/com/alibaba/csp/sentinel/util/MethodUtil.java 76.92% <100%> (ø) 3 <1> (ø) ⬇️
.../src/main/java/com/alibaba/csp/sentinel/CtSph.java 65.9% <100%> (ø) 8 <0> (ø) ⬇️
...ntinel/slots/statistic/metric/WindowLeapArray.java 70.96% <0%> (-9.68%) 7% <0%> (-1%)
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 61.4% <0%> (-5.27%) 15% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a3ef2...4449bcf. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Aug 4, 2018
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30
Copy link
Member

sczyh30 commented Aug 4, 2018

Thanks for your contribution. Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=34

@sczyh30 sczyh30 merged commit 8075232 into alibaba:master Aug 5, 2018
@sczyh30 sczyh30 removed the to-review To review label Aug 5, 2018
sczyh30 pushed a commit that referenced this pull request Aug 8, 2018
Modify MethodUtil#methodNameMap and CtSph#chainMap: add `volatile` to keep in line with others
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
Modify MethodUtil#methodNameMap and CtSph#chainMap: add `volatile` to keep in line with others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants