Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some code against the Alibaba Java Coding Guidelines #14

Closed
jarvisxiong opened this issue Jul 31, 2018 · 1 comment
Closed

Some code against the Alibaba Java Coding Guidelines #14

jarvisxiong opened this issue Jul 31, 2018 · 1 comment
Assignees
@sczyh30
Labels
typo-or-format Typo fix or reformat

Comments

@jarvisxiong
Copy link

Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/block/flow/controller/WarmUpController.java

Line 149 in 2f8a818

storedTokens.set(0l);

阿里插件提示，需long型常量大写L结尾，避免混淆。
@sczyh30
Copy link
Member

sczyh30 commented Jul 31, 2018

We'll fix this for the legacy code. Thanks for reporting!

@sczyh30 sczyh30 added the typo-or-format Typo fix or reformat label Jul 31, 2018
@sczyh30 sczyh30 self-assigned this Jul 31, 2018
@sczyh30 sczyh30 changed the title 阿里开发规约 Some code against the Alibaba Java Coding Guidelines Jul 31, 2018
sczyh30 added a commit that referenced this issue Aug 8, 2018
@sczyh30
Fixes #14: Apply Alibaba Java Coding Guidelines
d496cb0 
Signed-off-by: Eric Zhao <[email protected]>
Arlmls pushed a commit to Arlmls/Sentinel that referenced this issue Jan 8, 2019
@sczyh30
Fixes alibaba#14: Apply Alibaba Java Coding Guidelines
9bd2a62 
Signed-off-by: Eric Zhao <[email protected]>
@keybersan keybersan mentioned this issue Jul 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sczyh30 sczyh30

Labels
typo-or-format Typo fix or reformat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sczyh30 @jarvisxiong