Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread pools should be created with NamedThreadFactory for identification #9

Closed
CodeIngL opened this issue Jul 30, 2018 · 1 comment · Fixed by #10
Closed

Thread pools should be created with NamedThreadFactory for identification #9

CodeIngL opened this issue Jul 30, 2018 · 1 comment · Fixed by #10
Assignees
@sczyh30
Labels
kind/enhancement Category issues or prs related to enhancement.
Milestone
0.1.1

Comments

@CodeIngL
Copy link

里面看到了NamedThreadFactory。为了更好区分线程信息，应该

Executors.newScheduledThreadPool(x)

进行修改

new ScheduledThreadPoolExecutor(X, new NamedThreadFactory("stl-${something}"));
@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Jul 30, 2018
@sczyh30 sczyh30 changed the title Executors.newScheduledThreadPool(x) Thread pools should be created with NamedThreadFactory for identification Jul 30, 2018
@sczyh30 sczyh30 self-assigned this Jul 30, 2018
@sczyh30
Copy link
Member

sczyh30 commented Jul 30, 2018

Yes, the thread pools should be created with NamedThreadFactory for clear identification. We'll fix this. Thanks for your suggestion!

@sczyh30 sczyh30 mentioned this issue Jul 30, 2018
Merged
sczyh30 added a commit that referenced this issue Jul 30, 2018
@sczyh30
Fixes #9: Use named thread factory for identification (#10)
47d9070 
* Use named thread factory with all thread pools for identification

Signed-off-by: Eric Zhao <[email protected]>
@sczyh30 sczyh30 added this to the 0.1.1 milestone Jul 30, 2018
sczyh30 added a commit that referenced this issue Aug 8, 2018
@sczyh30
Fixes #9: Use named thread factory for identification (#10)
c4741a0 
* Use named thread factory with all thread pools for identification

Signed-off-by: Eric Zhao <[email protected]>
Arlmls pushed a commit to Arlmls/Sentinel that referenced this issue Jan 8, 2019
@sczyh30
Fixes alibaba#9: Use named thread factory for identification (alibaba#10
94f468a 
)

* Use named thread factory with all thread pools for identification

Signed-off-by: Eric Zhao <[email protected]>
@keybersan keybersan mentioned this issue Jul 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sczyh30 sczyh30

Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

Fixes #9: Use named thread factory for identification alibaba/Sentinel
2 participants
@sczyh30 @CodeIngL