Skip to content

FNet3 proto#6162

Merged
cce merged 10 commits intoalgorand:dev/experimental-incentivesfrom
tasosbit:fnet3
Nov 8, 2024
Merged

FNet3 proto#6162
cce merged 10 commits intoalgorand:dev/experimental-incentivesfrom
tasosbit:fnet3

Conversation

@tasosbit
Copy link
Copy Markdown
Contributor

PR against dev/experimental-incentives for users wanting to build the current FNet client from the official repo

  • proto change: disables challenges; without heartbeats, participating accounts can be evicted unfairly.
  • fixes the vFuture values as vFnet1/2 by values rather than reference/copy, which was something on the TODO list per this discussion
  • goal wallet new -n non interactive wallet creation. Standalone PR against master
  • goal wallet rename old new wallet renaming. Standalone PR against master

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 34.92063% with 41 lines in your changes missing coverage. Please review.

Project coverage is 56.23%. Comparing base (471d206) to head (fdec56b).
Report is 12 commits behind head on dev/experimental-incentives.

Files with missing lines Patch % Lines
cmd/goal/wallet.go 5.71% 33 Missing ⚠️
libgoal/wallets.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           dev/experimental-incentives    #6162      +/-   ##
===============================================================
+ Coverage                        56.20%   56.23%   +0.02%     
===============================================================
  Files                              494      494              
  Lines                            69961    70015      +54     
===============================================================
+ Hits                             39323    39373      +50     
- Misses                           27962    27970       +8     
+ Partials                          2676     2672       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cce cce merged commit edd2ff6 into algorand:dev/experimental-incentives Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants