Skip to content

goal: added "wallet rename"#6161

Merged
gmalouf merged 2 commits intoalgorand:masterfrom
tasosbit:feat/goal-wallet-rename
Feb 21, 2025
Merged

goal: added "wallet rename"#6161
gmalouf merged 2 commits intoalgorand:masterfrom
tasosbit:feat/goal-wallet-rename

Conversation

@tasosbit
Copy link
Copy Markdown
Contributor

Added a goal wrapper to the KMD rename wallet API

Usage: goal wallet rename [current wallet name] [new wallet name]

@tasosbit tasosbit mentioned this pull request Oct 31, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 3.22581% with 30 lines in your changes missing coverage. Please review.

Project coverage is 56.25%. Comparing base (eff5fb4) to head (fe10c8e).
Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
cmd/goal/wallet.go 4.34% 22 Missing ⚠️
libgoal/wallets.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6161      +/-   ##
==========================================
- Coverage   56.29%   56.25%   -0.04%     
==========================================
  Files         494      494              
  Lines       69958    69989      +31     
==========================================
- Hits        39381    39372       -9     
- Misses      27907    27939      +32     
- Partials     2670     2678       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it tested? consider adding a new e2e expect test

jannotti
jannotti previously approved these changes Nov 12, 2024
Copy link
Copy Markdown
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to accept even without expect script test. I find those expect scripts painful to read/write, and to me this is essentially "UI", we need not be as concerned about perfect correctness here as we try to be on the protocol. This change amounts to little more than a prepackaged curl command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants