Merged
Conversation
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6161 +/- ##
==========================================
- Coverage 56.29% 56.25% -0.04%
==========================================
Files 494 494
Lines 69958 69989 +31
==========================================
- Hits 39381 39372 -9
- Misses 27907 27939 +32
- Partials 2670 2678 +8 ☔ View full report in Codecov by Sentry. |
algorandskiy
reviewed
Nov 4, 2024
Contributor
algorandskiy
left a comment
There was a problem hiding this comment.
Was it tested? consider adding a new e2e expect test
jannotti
previously approved these changes
Nov 12, 2024
Contributor
There was a problem hiding this comment.
I'm inclined to accept even without expect script test. I find those expect scripts painful to read/write, and to me this is essentially "UI", we need not be as concerned about perfect correctness here as we try to be on the protocol. This change amounts to little more than a prepackaged curl command.
jannotti
reviewed
Nov 27, 2024
jannotti
reviewed
Nov 27, 2024
algorandskiy
approved these changes
Feb 21, 2025
gmalouf
approved these changes
Feb 21, 2025
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a goal wrapper to the KMD rename wallet API
Usage:
goal wallet rename [current wallet name] [new wallet name]