FNet: named current future protocol as "fnet1"

[tasosbit]

Hardcoding the current future protocol as fnet1 to prevent inconsistent views of the protocol in AF FNet

Experimental / Not to be merged to main

[CLAassistant]

All committers have signed the CLA.

[cce]

vFuture can receive changes as part of the development process until the next consensus release, so defining vFnet1 here as a copy of vFuture does not pin it down as firmly as if you started from a copy of the last consensus release (v39).

[tasosbit]

I'm aware re: future, the idea here was to update the code to fix fnet1 to the current values for now, and when we need fnet2 to shadow the next future, fnet1 would be defined explicitly from v39 as you say.
The FNet nodes will track from this dev branch, so updates to future on main will not affect them until we update the branch

[cce]

oh I was confused because this PR is set to merge to master — so you are going to cut a dev branch of master after this?

[onetechnical]

I think you want to pin down fnet1 to last consensus version + the items you want to include, because you won't automatically include new vFuture items when the software gets upgraded. We're not upgrading it wily nily here, but if you rebase on master you'll have to tear down and rebuild the network. (This may be fine for your purposes.)

[onetechnical]

Oh, this should not target master, good catch @cce

[tasosbit]

yep - sorry about that, changed the base to dev/experimental-incentives

[tasosbit]

Is this CircleCI test failure expected? It failed on TestP2PwsStreamHandlerDedup. Might be related to some maintenance they are doing atmo.

Can someone with privileges resubmit the job?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.27%. Comparing base (4990077) to head (fc4c2bf).
Report is 1 commits behind head on dev/experimental-incentives.

Additional details and impacted files

@@                     Coverage Diff                      @@
##           dev/experimental-incentives    #6113   +/-   ##
============================================================
  Coverage                        56.27%   56.27%           
============================================================
  Files                              490      490           
  Lines                            69710    69712    +2     
============================================================
+ Hits                             39230    39233    +3     
+ Misses                           27817    27815    -2     
- Partials                          2663     2664    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[urtho]

Can we get conduit support for fnet1 🙏