Skip to content

goal: add "wallet rename" functionality#3

Merged
tasosbit merged 3 commits intofnet3from
feat/goal-wallet-rename
Oct 23, 2024
Merged

goal: add "wallet rename" functionality#3
tasosbit merged 3 commits intofnet3from
feat/goal-wallet-rename

Conversation

@tasosbit
Copy link
Copy Markdown
Owner

@tasosbit tasosbit commented Oct 21, 2024

No description provided.

Copy link
Copy Markdown

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the lint error it LGTM

goal wallet rename default defunked && goal wallet list
Renamed wallet 'default' to 'defunked'
##################################################
Wallet: defunked (default)
ID:     ab4e6aa1f05e6aa91eab7caf8c66f95f
##################################################

@tasosbit tasosbit changed the title goal: add wallet rename functionality goal: add "wallet rename" functionality Oct 22, 2024
Copy link
Copy Markdown

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@nullun nullun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected, just two comments.

@tasosbit tasosbit changed the base branch from fnet2 to fnet3 October 23, 2024 15:10
@tasosbit tasosbit merged commit 165ae35 into fnet3 Oct 23, 2024
@tasosbit tasosbit deleted the feat/goal-wallet-rename branch October 23, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants