ledger: add kvIter to storage package (11 of N) #4892
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Dec 16, 2022
Merged
ledger: add kvIter to storage package (11 of N) #4892algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
e5f9df8 to
54b4979
Compare
Codecov Report
@@ Coverage Diff @@
## master #4892 +/- ##
==========================================
- Coverage 53.69% 53.64% -0.05%
==========================================
Files 430 431 +1
Lines 53529 53536 +7
==========================================
- Hits 28741 28722 -19
- Misses 22560 22586 +26
Partials 2228 2228
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
54b4979 to
37db992
Compare
algorandskiy
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handles the last remaining queries left in
ledgerused in production code.A few sql statements remain in specific tests.
Previous parts of this refactor:
What remains to be moved out:
ledgeracctdeltas_test.goacctupdates_test.gocatchpointtracker.gocatchpointwriter.gocatchpointwriter_test.goTest Plan
Existing tests.