ledger: move catchpoint sql code into storage package#4813
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Nov 22, 2022
Merged
ledger: move catchpoint sql code into storage package#4813algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
icorderi
force-pushed
the
refactor/accountdb-2
branch
3 times, most recently
from
41eb8f4 to
694dd4e
Compare
icorderi
force-pushed
the
refactor/accountdb-2
branch
from
694dd4e to
245d0dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4813 +/- ##
==========================================
- Coverage 54.20% 54.03% -0.17%
==========================================
Files 419 420 +1
Lines 53750 53765 +15
==========================================
- Hits 29137 29054 -83
- Misses 22231 22337 +106
+ Partials 2382 2374 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| stagingWriter: &stagingWriterImpl{wdb: ledger.trackerDB().Wdb}, | ||
| log: log, | ||
| ledger: ledger, | ||
| catchpointStore: store.NewCatchpointSQLReaderWriter(ledger.trackerDB().Wdb.Handle), |
Contributor
There was a problem hiding this comment.
in theory we might use separate reader and writer handles. for sqlite it does not matter but still
icorderi
force-pushed
the
refactor/accountdb-2
branch
from
37c3b3f to
dc45020
Compare
algorandskiy
approved these changes
Nov 22, 2022
algorandskiy
changed the title
accountdb.go into a storage package (2 of N)
This was referenced Nov 22, 2022
This was referenced Nov 30, 2022
This was referenced Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moving some of the catchpoint sql queries into the store package.
Previous parts of this refactor:
Test Plan
Existing tests.