ledger: move blockdb into a storage package (6 of N)#4841
Merged
Conversation
icorderi
force-pushed
the
refactor/accountdb-6
branch
from
c100ab7 to
1e877e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #4841 +/- ##
==========================================
- Coverage 53.44% 53.31% -0.13%
==========================================
Files 422 422
Lines 53858 53698 -160
==========================================
- Hits 28782 28628 -154
- Misses 22782 22797 +15
+ Partials 2294 2273 -21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
icorderi
force-pushed
the
refactor/accountdb-6
branch
from
9e234e1 to
299c75c
Compare
| } | ||
|
|
||
| func checkBlockDB(t *testing.T, tx *sql.Tx, blocks []blockEntry) { | ||
| next, err := blockNext(tx) |
Contributor
There was a problem hiding this comment.
this file should go into blockdb package along with the code it tests
This was referenced Dec 1, 2022
algorandskiy
approved these changes
Dec 5, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Ok, blockdb_test moved in part 8
algorandskiy
changed the title
This was referenced Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A clean move of
blockdbto its own package.This is to reduce some noice on the next PR that would cause circular dependencies with ledger if blockdb was kept there.
Included moving the hashing since it will also be needed for the next PR.
Previous parts of this refactor:
What remains to be moved out:
orderedAccountsItercatchpointPendingHashesIteratoraccountsLoadOldandresourcesLoadOldhave a couple queries that we might want to move out to avoid pulling all the deltas into storeTest Plan
Existing tests.