ledger: move catchpoint staging into a storage package (5 of N)#4836
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Nov 30, 2022
Merged
ledger: move catchpoint staging into a storage package (5 of N)#4836algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4836 +/- ##
==========================================
- Coverage 53.54% 53.39% -0.15%
==========================================
Files 422 422
Lines 53852 53858 +6
==========================================
- Hits 28834 28758 -76
- Misses 22697 22805 +108
+ Partials 2321 2295 -26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
icorderi
force-pushed
the
refactor/accountdb-5
branch
2 times, most recently
from
d13ca24 to
78c5554
Compare
icorderi
force-pushed
the
refactor/accountdb-5
branch
from
78c5554 to
337db29
Compare
9 tasks
algorandskiy
approved these changes
Nov 30, 2022
algorandskiy
changed the title
accountdb.go into a store package (5 of N)
9 tasks
This was referenced Dec 5, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue moving methods out of
accountdb.go.This PR particularly moves "catchpoint staging".
Previous parts of this refactor:
What remains to be moved out:
orderedAccountsItercatchpointPendingHashesIteratoraccountsLoadOldandresourcesLoadOldhave a couple queries that we might want to move out to avoid pulling all the deltas into storeTest Plan
Existing tests.