Skip to content

⚙️ Engine: Hoist Intl.DateTimeFormat & Zero-Allocation ISO Date Slicing - #1498

Closed
alehar9320 wants to merge 1 commit into
mainfrom
engine/hoist-intl-and-zero-alloc-date-slicing-9289240210410555636
Closed

alehar9320 wants to merge 1 commit into
mainfrom
engine/hoist-intl-and-zero-alloc-date-slicing-9289240210410555636

Conversation

@alehar9320

@alehar9320 alehar9320 commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Optimized date formatting utilities across edge API and SSR pathways in Cloudflare Workers edge runtimes. Hoisted Intl.DateTimeFormat instance (stockholmDateFormatter) in visit-stats.ts to module scope to eliminate ICU locale re-initialization and dynamic GC object allocations on every request. Refactored formatReleaseDate in github-releases.ts from date.toISOString().split('T')[0] to date.toISOString().slice(0, 10) to eliminate dynamic 2-element array allocations during ISO date formatting. Expanded Vitest unit tests in github-releases.test.ts and visit-stats.test.ts to cover leap years, millisecond ISO formats, and empty string edge cases. Documented architectural updates in .Jules/engine.md.


PR created automatically by Jules for task 9289240210410555636 started by @alehar9320

Summary by CodeRabbit

  • Bug Fixes
    • Release dates that include fractional seconds now display correctly, including leap-day dates.
    • Empty release dates continue to display as “Unknown date,” while empty first-seen dates display no date.
    • First-seen dates retain their existing locale and time-zone formatting, with invalid dates still producing an empty result.

Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@alehar9320
alehar9320 temporarily deployed to engine/hoist-intl-and-zero-alloc-date-slicing-9289240210410555636 - astro-cloudflare-personal-website-web-service PR #1498 September 30, 2026 02:16 — with Render Destroyed
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 67c937ba-97cb-4a44-9598-5890132a9d34

📥 Commits

Reviewing files that changed from the base of the PR and between 9ff88fc and cd291ed.

📒 Files selected for processing (5)
  • .Jules/engine.md
  • src/__tests__/github-releases.test.ts
  • src/utils/github-releases.ts
  • src/utils/visit-stats.test.ts
  • src/utils/visit-stats.ts
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 562.07kB (-48.89%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
molecular-mars-esm 587.7kB -562.07kB (-48.89%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: molecular-mars-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_astro/page.CTkWqDz_.js (New) 331.33kB 331.33kB 100.0% 🚀
_astro/module.Cxg7Azad.js (New) 240.43kB 240.43kB 100.0% 🚀
_astro/Chat.astro_astro_type_script_index_0_lang.Q2vE5BL0.js (New) 11.15kB 11.15kB 100.0% 🚀
_astro/PostHog.astro_astro_type_script_index_0_lang.BtlOOJ3a.js (New) 2.17kB 2.17kB 100.0% 🚀
_astro/hire-analytics.Dv8r_0bC.js (New) 1.37kB 1.37kB 100.0% 🚀
_astro/BaseLayout.astro_astro_type_script_index_0_lang.2uq-xTMa.js (New) 690 bytes 690 bytes 100.0% 🚀
_astro/contact.astro_astro_type_script_index_0_lang.9F6uSCoD.js (New) 554 bytes 554 bytes 100.0% 🚀
chunks/whats-new_BankhB0t.mjs (Deleted) -280.3kB 0 bytes -100.0% 🗑️
chunks/default-handler_DqHG8eeJ.mjs (Deleted) -192.27kB 0 bytes -100.0% 🗑️
chunks/traceData_Dr_fxZBz.mjs (Deleted) -126.65kB 0 bytes -100.0% 🗑️
chunks/schemas_Cot3sONg.mjs (Deleted) -126.52kB 0 bytes -100.0% 🗑️
chunks/server_2oEWh56Y.mjs (Deleted) -105.31kB 0 bytes -100.0% 🗑️
chunks/assets_lTcd8Z19.mjs (Deleted) -57.34kB 0 bytes -100.0% 🗑️
chunks/sequence_CaMmmLod.mjs (Deleted) -47.7kB 0 bytes -100.0% 🗑️
_astro/whats-new.Bf7CHJhQ.css (Deleted) -43.09kB 0 bytes -100.0% 🗑️
chunks/shorthash_CUWuunCX.mjs (Deleted) -29.34kB 0 bytes -100.0% 🗑️
chunks/image-binding-transform_Cf-85Vgs.mjs (Deleted) -24.19kB 0 bytes -100.0% 🗑️
chunks/_astro_data-layer-content_BvrnG9KS.mjs (Deleted) -19.62kB 0 bytes -100.0% 🗑️
virtual_astro_middleware.mjs (Deleted) -15.63kB 0 bytes -100.0% 🗑️
chunks/parse_Ba8fytvn.mjs (Deleted) -15.01kB 0 bytes -100.0% 🗑️
chunks/chat_zD7YyXHs.mjs (Deleted) -12.01kB 0 bytes -100.0% 🗑️
chunks/visits_CH9uXrqX.mjs (Deleted) -8.18kB 0 bytes -100.0% 🗑️
chunks/visitor-changelog_BxY0qWCV.mjs (Deleted) -6.98kB 0 bytes -100.0% 🗑️
chunks/github-releases_BV2_eBm_.mjs (Deleted) -6.7kB 0 bytes -100.0% 🗑️
entry.mjs (Deleted) -5.7kB 0 bytes -100.0% 🗑️
chunks/release-summary_38ArvXd3.mjs (Deleted) -4.97kB 0 bytes -100.0% 🗑️
chunks/release-summary_CjrmKGpt.mjs (Deleted) -4.91kB 0 bytes -100.0% 🗑️
chunks/_virtual_astro_session-driver__DuTqh8b.mjs (Deleted) -3.47kB 0 bytes -100.0% 🗑️
chunks/static-image-collection_BCOQ0UCH.mjs (Deleted) -2.85kB 0 bytes -100.0% 🗑️
chunks/releases_BfVji4Vx.mjs (Deleted) -2.19kB 0 bytes -100.0% 🗑️
chunks/image-transform-endpoint_iHq_WzOS.mjs (Deleted) -1.83kB 0 bytes -100.0% 🗑️
chunks/compiler_CI7zcT-L.mjs (Deleted) -1.77kB 0 bytes -100.0% 🗑️
chunks/consts_J54VxCWf.mjs (Deleted) -1.12kB 0 bytes -100.0% 🗑️
chunks/image-service-workerd_DAtwUGVM.mjs (Deleted) -960 bytes 0 bytes -100.0% 🗑️
chunks/rolldown-runtime_CsW08brr.mjs (Deleted) -941 bytes 0 bytes -100.0% 🗑️
chunks/_virtual_astro_server-island-manifest_ms-rvHw7.mjs (Deleted) -798 bytes 0 bytes -100.0% 🗑️
chunks/content-assets_CKY12EWb.mjs (Deleted) -732 bytes 0 bytes -100.0% 🗑️
chunks/noop-entrypoint_BWurWioB.mjs (Deleted) -680 bytes 0 bytes -100.0% 🗑️

@mergify

mergify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@cloudflare-workers-and-pages

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
me cd291ed Commit Preview URL

Branch Preview URL
Sep 30 2026, 02:17 AM

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

HARD ABORT — Engine Intl hoist + ISO date-slice Jules farm (no merge)

Owner value bar: Engine/Bolt has the same bar as Jules/Palette/Prism — no junk micro-opts onto main for a personal branding site.

Classification: Exact restack of the Engine/Bolt Intl.DateTimeFormat hoist + zero-allocation ISO date-slicing class overlapping Dual CLOSE HOLD #1204 tip 854866c7 (github-releases.ts .slice(0,10) + visit-stats.ts module-scope Stockholm formatter).

Prior closes (same class): #1497 tip de8a645f (2026-09-30 ~02:46 CEST), #1485 tip e0429f8d (2026-09-29 ~03:05 CEST), #1472, #1460, #1448, #1436, #1424, #1412, #1400, #1388, #1374, #1357, etc.

This PR: tip cd291ed5 FULL cd291ed5fb648a2f153875215e4529d2542161cb — files .Jules/engine.md (backdated 2025-06-18) + src/utils/github-releases.ts (.split('T')[0] → .slice(0, 10)) + src/utils/visit-stats.ts (stockholmDateFormatter hoist) + test expansions. Zero visitor/branding value.

@jules do not restack. Do not reopen. Do not Jules-restack this class again. Soft dims N/A.

Closing unmerged as alehar9320-bot. Stay off #800. Overlay 69ca717. Hire LinkedIn. Do not reopen #1204. Live 9ff88fc1. Bot only.

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

This branch was successfully deployed

No deployments
engine/hoist-intl-and-zero-alloc-date-slicing-9289240210410555636 - astro-cloudflare-personal-website-web-service PR #1498 — cd291ed5 Deployed Sep 30, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants