Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocates lists and associated relationship retrieval from M365 #4785

Closed
wants to merge 13 commits into from

Conversation

@HiteshRepo HiteshRepo added backup sharepoint lists category of sharepoint service labels Dec 2, 2023
@HiteshRepo HiteshRepo self-assigned this Dec 2, 2023
Copy link
Contributor

aviator-app bot commented Dec 2, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Member

@meain meain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the individual PRs were separately looked at and approved.

@HiteshRepo
Copy link
Contributor Author

Approving as the individual PRs were separately looked at and approved.

yes.all chained PRs have been approved and merged into this. Added them to the description.

this allows creation of restore paths for sharepoint lists.
Below changes got lost during PR merges:
- #4855

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🐛 Bugfix

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@HiteshRepo
Copy link
Contributor Author

Approving as the individual PRs were separately looked at and approved.

yes.all chained PRs have been approved and merged into this. Added them to the description.

@ryanfkeepers can we merge this? The other PRs got chained from this and this has grown big as a result.

@meain
Copy link
Member

meain commented Dec 22, 2023

ryanfkeepers can we merge this? The other PRs got chained from this and this has grown big as a result.

Let's go ahead and merge this as this PR only contains code from other PRs that have been already reviewed. Next time, let's make sure to merge them one-by-one instead of combining into a single PR and merging to main. This also help making bisect more useful.

@HiteshRepo HiteshRepo mentioned this pull request Dec 22, 2023
5 tasks
aviator-app bot pushed a commit that referenced this pull request Dec 22, 2023
adds list client apis and pagers to fetch, create and delete lists and list relations.
Changes previously approved in PRs:
- #4785
- #4815
- #4852

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
@HiteshRepo
Copy link
Contributor Author

HiteshRepo commented Dec 22, 2023

ryanfkeepers can we merge this? The other PRs got chained from this and this has grown big as a result.

Let's go ahead and merge this as this PR only contains code from other PRs that have been already reviewed. Next time, let's make sure to merge them one-by-one instead of combining into a single PR and merging to main. This also help making bisect more useful.

In case of regression(if any), this PR will cause difficult to hunt the cause. This has been broken down into multiple PRs of logically grouped approved changes.

will close this once all of them are merged

@HiteshRepo
Copy link
Contributor Author

ryanfkeepers can we merge this? The other PRs got chained from this and this has grown big as a result.

Let's go ahead and merge this as this PR only contains code from other PRs that have been already reviewed. Next time, let's make sure to merge them one-by-one instead of combining into a single PR and merging to main. This also help making bisect more useful.

In case of regression(if any), this PR will cause difficult to hunt the cause. This has been broken down into multiple PRs of logically grouped approved changes.

will close this once all of them are merged

closing this as all PRs have been merged

@HiteshRepo HiteshRepo closed this Dec 22, 2023
@HiteshRepo HiteshRepo deleted the 4754-backup-1 branch December 28, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backup lists category of sharepoint service sharepoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants