-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relocates lists and associated relationship retrieval from M365 #4785
Conversation
Current Aviator status
This PR was closed without merging. If you still want to merge this PR, re-open it. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as the individual PRs were separately looked at and approved.
yes.all chained PRs have been approved and merged into this. Added them to the description. |
this allows creation of restore paths for sharepoint lists. Below changes got lost during PR merges: - #4855 #### Does this PR need a docs update or release note? - [x] ⛔ No #### Type of change <!--- Please check the type of change your PR introduces: ---> - [x] 🐛 Bugfix #### Issue(s) #4754 #### Test Plan <!-- How will this be tested prior to merging.--> - [x] 💪 Manual - [x] ⚡ Unit test - [x] 💚 E2E
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 4 New issues |
@ryanfkeepers can we merge this? The other PRs got chained from this and this has grown big as a result. |
Let's go ahead and merge this as this PR only contains code from other PRs that have been already reviewed. Next time, let's make sure to merge them one-by-one instead of combining into a single PR and merging to main. This also help making bisect more useful. |
adds list client apis and pagers to fetch, create and delete lists and list relations. Changes previously approved in PRs: - #4785 - #4815 - #4852 #### Does this PR need a docs update or release note? - [x] ⛔ No #### Type of change <!--- Please check the type of change your PR introduces: ---> - [x] 🌻 Feature #### Issue(s) #4754 #### Test Plan <!-- How will this be tested prior to merging.--> - [x] 💪 Manual - [x] ⚡ Unit test - [x] 💚 E2E
In case of regression(if any), this PR will cause difficult to hunt the cause. This has been broken down into multiple PRs of logically grouped approved changes.
will close this once all of them are merged |
closing this as all PRs have been merged |
removes retrieval lists and its relationships from collections/sites package
add retrieval lists and its relationships to /api/lists client wrapper
apart from above, this PRs accumulates changes from other chained PRs:
for restore backups
for list backups
Does this PR need a docs update or release note?
Type of change
Issue(s)
#4754
Test Plan