Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables restore paths creation and some cleanup #4855

Merged
merged 24 commits into from
Dec 21, 2023

Conversation

HiteshRepo
Copy link
Contributor

  • removes delete lists function from collections package
  • enables restore paths creation
  • relocates restore lists collection test

Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🧹 Tech Debt/Cleanup

Issue(s)

#4754

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@HiteshRepo HiteshRepo added restore sharepoint lists category of sharepoint service labels Dec 14, 2023
@HiteshRepo HiteshRepo self-assigned this Dec 14, 2023
Copy link
Contributor

aviator-app bot commented Dec 14, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@meain
Copy link
Member

meain commented Dec 18, 2023

@ryanfkeepers @HiteshRepo I'm a bit OOTL on the discussion around the path format. Was there any reasoning behind using the id as the filename? Should we just use a fixed value like data. I don't see using the id providing any advantage (unless we remove one more top level folder where we use the name).

I like the current format of having a folder for each list so that it is easier for us to add any additional metadata or split the current file in future. Using names for the folder also seems OK as SharePoint does not seem to let one create lists with duplicate names.

@HiteshRepo
Copy link
Contributor Author

@ryanfkeepers @HiteshRepo I'm a bit OOTL on the discussion around the path format. Was there any reasoning behind using the id as the filename? Should we just use a fixed value like data. I don't see using the id providing any advantage (unless we remove one more top level folder where we use the name).

I like the current format of having a folder for each list so that it is easier for us to add any additional metadata or split the current file in future. Using names for the folder also seems OK as SharePoint does not seem to let one create lists with duplicate names.

@meain changed kopia loc for list dir name from list-name to list-id and the file name is also going to be list-id itself instead of 'data'. #4893

…4870)

ignore lists with `webTemplateExtensionsList` template while creation in
order to avoid `invalid template` graph error

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@HiteshRepo HiteshRepo merged commit 74610b5 into 4754-backup-1 Dec 21, 2023
14 of 15 checks passed
@HiteshRepo HiteshRepo deleted the 4754-restore-6 branch December 21, 2023 04:52
HiteshRepo added a commit that referenced this pull request Dec 21, 2023
this allows creation of restore paths for sharepoint lists.
Below changes got lost during PR merges:
- #4855

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🐛 Bugfix

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
aviator-app bot pushed a commit that referenced this pull request Dec 22, 2023
Enable restore path creation for sharepoint lists
Changes previously approved in: #4855

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lists category of sharepoint service restore sharepoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants