Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements lists backup handler #4786

Merged
merged 8 commits into from
Dec 5, 2023
Merged

implements lists backup handler #4786

merged 8 commits into from
Dec 5, 2023

Conversation

HiteshRepo
Copy link
Contributor

introduces sharepoint backup handler
implements lists backup handler
instantiates and propagates the lists backup handler to downstream
add a test for CollectLists

Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🌻 Feature

Issue(s)

#4754

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@HiteshRepo HiteshRepo added backup sharepoint lists category of sharepoint service labels Dec 2, 2023
@HiteshRepo HiteshRepo self-assigned this Dec 2, 2023
Copy link
Contributor

aviator-app bot commented Dec 2, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@HiteshRepo HiteshRepo changed the title implemnets lists backup handler implements lists backup handler Dec 3, 2023
Comment on lines 11 to 13
type GetList struct {
Err error
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it's likely we'll later want to expand this to mock the whole backup handler. Might as well set it up now.

Suggested change
type GetList struct {
Err error
}
type ListHandler struct {
ListItem models.Listable
Err error
}

HiteshRepo and others added 2 commits December 6, 2023 00:26
fetches lists and its relationships using Lists client wrapper

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HiteshRepo HiteshRepo merged commit a0e56c8 into 4754-backup-1 Dec 5, 2023
24 of 25 checks passed
@HiteshRepo HiteshRepo deleted the 4754-backup-2 branch December 5, 2023 19:25
HiteshRepo added a commit that referenced this pull request Dec 21, 2023
<!-- PR description-->
introduces sharepoint backup handler
implements lists backup handler
instantiates and propagates the lists backup handler to downstream
add a test for CollectLists

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
HiteshRepo added a commit that referenced this pull request Dec 21, 2023
<!-- PR description-->
introduces sharepoint backup handler
implements lists backup handler
instantiates and propagates the lists backup handler to downstream
add a test for CollectLists

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
aviator-app bot pushed a commit that referenced this pull request Dec 22, 2023
adds list backup and restore handlers
Changes previously approved in:
- #4786
- #4854

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
aviator-app bot pushed a commit that referenced this pull request Dec 22, 2023
enables sharepoint to use lists backup handler for lists ops
Changes previously approved in:
-  #4786
- #4787
- #4909

#### Does this PR need a docs update or release note?
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

#### Issue(s)
#4754 

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backup lists category of sharepoint service sharepoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants