relocate list and pages de-serialization functions

[HiteshRepo]

relocate list and pages de-serialization functions

Does this PR need a docs update or release note?

• ⛔ No

Type of change

• 🧹 Tech Debt/Cleanup

Issue(s)

#4754

Test Plan

• 💪 Manual
• ⚡ Unit test
• 💚 E2E

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[ryanfkeepers]

@HiteshRepo I assume this is only code movement, and contains no changes to the code itself. But it's difficult to know for sure, because the number of line additions and deletions is substantially different: 329 lines added, 283 removed. Can you please confirm whether you made any changes as part of moving the code?

What's helpful for PRs like this is if you can write something in the description to state whether reviewers need to look for additional changes. Something like: "No changes to logic in this PR; I only moved/renamed code." That'll give us extra confidence that the changes are simple and we don't need to investigate every line that was moved for comparison.

[HiteshRepo]

e this is only code movement, and contains no changes to the code itself. But it's difficult to know for sure, because the number of line additions and deletions is substantially different: 329 lines added, 283 removed. Can you please confirm whether you made any changes as part of moving the code?

There is no code changes @ryanfkeepers in this PR. I separated the code changes in subsequent PRs branching out for this branch.

But here is the breakup:

1. 187 lines removed from api/serialization.go
   • 171 lines added to api/lists.go
   • 13 lines added to api/pages.go
2. 102 lines removed from api/serialization_test.go
   • 50 lines added to api/lists_test.go
   • 72 lines added to api/pages_test.go
   • 20 extra lines added because of setting up suite individually for pages and list
3. rest are just renaming of functions from 'CreatePageFromBytes' to 'BytesToSitePageable' & 'CreateListFromBytes' to 'BytesToListable'

I think the 20-23 extra lines that got added that gets doubled and makes it a 46 gap b/w added and removed.

[ryanfkeepers]

thank you for the explanation!

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud