Repository navigation
CI: exclude misconfigured Vera Rubin nodes from nixl-ci-gpu-vr - #2339
Conversation
vr-nvl72-ts3-l06-comp137, comp139, comp141 and vr-nvl72-ts2b-l10-comp102 are configured differently from the rest of the vrnvl72 partition, and test_prep_mem_view fails on them deterministically (UCX "lane not found for element 0" on the remote mem-view) while passing on the other nodes. Exclude them from the Slurm allocation via SLURM_EXCLUDE, the same variable test-llm-container-matrix.yaml already passes as --exclude. Signed-off-by: NirWolfer <nwolfer@nvidia.com>
|
👋 Hi NirWolfer! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/build |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe Vera Rubin GPU test matrix now passes four configured node exclusions to Slurm allocation. The CI overview documents the ChangesVera Rubin GPU node exclusions
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change documents and configures the four node exclusions. No concrete merge-blocking failure is established, though the allocation library’s handling of the argument remains unconfirmed. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🤖 CI Triage Agent — TL;DR: The only failure is Full analysisSummary: Stage 580 "Test Python" (ubuntu22 variant) failed: 1 of 28 pytest tests failed with Root cause: Implicated commit: File: Suggested fix: Stop depending on a pre-assigned fixed port in this test. Preferred: pass Related: PR #2148 (added the test); no existing issue tracks this flake — worth opening one. |
`nixl-ci-gpu-vr` runs keep failing in Allocate Environment: `salloc` waits in the `vrnvl72` queue for the whole `--immediate=3600` window, then fails with `Unable to allocate resources: Connection timed out`. That happened six times on 2026-10-05 (builds 93, 97, 100, 103, 104, 105). `vrnvl72` has 41 nodes, and on 2026-10-05 none were idle: 27 allocated, 4 mixed and held for higher-priority jobs, 5 drained, 2 in maintenance, and the 3 nodes we exclude were mixed. The job requests no GPU count, so the site plugin puts it in exclusive mode, and it can only start on a node that is completely idle. The exclude list from #2339 is not the cause: the 3 excluded nodes are in use by other jobs anyway, and `comp102` is not in `vrnvl72`. Requesting a GPU count lets the job start on a partly used node. A shorter time limit gives the scheduler more chances to fit it in ahead of larger jobs that are waiting. The tests adjust to the number of GPUs they see: the Python multi-GPU tests skip below 2, and the C++ tests use the device count. They also pick free ports, so sharing a node with another job is safe. Changes: - `.ci/jenkins/lib/test-vr-matrix.yaml` — request `--gres=gpu:2 --mem=128G --mincpus=24`, the same pattern `test-matrix.yaml` uses on mizu. - `.ci/jenkins/lib/test-vr-matrix.yaml` — reduce `SLURM_JOB_TIMEOUT` from `02:20:00` to `01:30:00` and size the step timeouts to the observed runtimes (about 35 min in total): cpp 60 → 45, python 20 → 15, rust 15 → 10, nixlbench 25 → 10. - `.ci/docs/ci-overview.md` — mention the 2-GPU request on the `nixl-ci-gpu-vr` entry. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * VR test jobs now request two GPUs, 128 GB of memory, and at least 24 CPUs instead of a whole node. * The overall job timeout is now 1 hour 30 minutes. Per-test timeouts are 15 minutes for Python, 10 minutes for Rust, 45 minutes for C++, and 10 minutes for Nixlbench. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: NirWolfer <nwolfer@nvidia.com>
Excludes four
vrnvl72nodes from thenixl-ci-gpu-vrSlurm allocation:vr-nvl72-ts3-l06-comp137,comp139,comp141vr-nvl72-ts2b-l10-comp102These nodes are configured differently from the rest of the partition. On them
test_prep_mem_viewfails deterministically — UCX rejects the remote mem-view withlane not found for element 0— while the same image and commit pass on the other nodes. In the bring-up runs every failure landed on an affected node and every pass on an unaffected one.Changes:
.ci/jenkins/lib/test-vr-matrix.yaml— newSLURM_EXCLUDEenv entry, passed as--exclude=${SLURM_EXCLUDE}in the allocation step'sextraArgs, the same waytest-llm-container-matrix.yamlalready does..ci/docs/ci-overview.md— note the exclusion on thenixl-ci-gpu-vrentry.Summary by CodeRabbit