chore(skills): flip canonical skill dir to skills/, demote .agents/skills to symlink - #10017
Merged
Conversation
github-actions
Bot
added
chore
documentation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (20)
💤 Files with no reviewable changes (2)
WalkthroughThe PR consolidates the ChangesSkills symlink consolidation
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
/nvskills-ci |
1 similar comment
Collaborator
Author
|
/nvskills-ci |
2 tasks
Contributor
…ills to symlink NVSkills CI watches changes under skills/ (vendored from NVIDIA/skills upstream). Pre-flip layout had skills under .agents/skills/ with skills/ as a root symlink, so NVSkills path-filter never matched skill changes and the signing dispatch was unreachable. Flip the canonical real directory to skills/ at the repo root. .agents/skills is now a symlink to ../skills, preserving the agentskills.io interop convention for clients that walk .agents/skills/ natively. Single source of truth on disk; both paths still resolve. Also drop the now-redundant 'skills' entry from the docs filter (.agents/** still covers the symlink) and update .gitignore so the new symlink isn't ignored. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Dan Gil <dagil@nvidia.com>
The flip moves skill content from .agents/skills/<x>/ (covered by .agents/**) to skills/<x>/ at the repo root, which wasn't matched by any filter pattern. changed-files CI fails with "Please add these paths to .github/filters.yaml" listing every new skill file. Add skills/** under docs: (skill content is documentation-shaped; doesn't trigger code-test jobs, but satisfies the coverage requirement). Same classification as the .agents/** glob that previously covered these paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Dan Gil <dagil@nvidia.com>
dagil-nvidia
force-pushed
the
chore/flip-skills-canonical-dir
branch
from
May 27, 2026 07:31
0d1b15a to
18eb882
Compare
saturley-hall
approved these changes
May 27, 2026
Collaborator
Author
|
/nvskills-ci |
3 tasks
Collaborator
Author
|
/nvskills-ci |
3 tasks
MartinRepo
pushed a commit
to MartinRepo/dynamo
that referenced
this pull request
May 28, 2026
…ills to symlink (ai-dynamo#10017) Signed-off-by: Dan Gil <dagil@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dagil-nvidia
added a commit
that referenced
this pull request
May 28, 2026
Touches each of the four skills under skills/ to add agentskills.io-compatible 'tags' fields. Matches the convention used by the NVIDIA/nvskills-ci reference skill (skills/ci-smoke-test/SKILL.md). Primary purpose: re-trigger the NVSkills CI validation flow that was first exercised on PR #10017 (now merged). That dispatch reached the downstream GitLab pipeline 52784444 but failed at validate:content with no per-skill detail in the GitHub-side log. This PR re-runs the path so the GitLab validate:content log is fresh and inspectable, and adds a frontmatter field that may be the underlying validation gap. No content changes; SKILL.md bodies, references, scripts, and evals are unmodified. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Dan Gil <dagil@nvidia.com>
saturley-hall
added a commit
that referenced
this pull request
May 29, 2026
Five doc URLs reference paths that no longer exist at blob/main but DO
exist on this release branch (and therefore on the v1.2.0 tag built from
it):
- .agents/skills/{dynamo-docs,tool-parser-generator}/SKILL.md (renamed to
.agents/contributor-skills/ on main, PR #10017)
- benchmarks/llm/perf.sh (renamed to benchmarks/frontend/scripts/ on main)
- deploy/inference-gateway/standalone/helm/dynamo-gaie/ (removed when the
standalone EPP chart was deprecated, PR #10001)
Adding them to .lycheeignore keeps lychee CI green on the release branch.
Fern's existing blob/main → blob/vX.Y.Z rewrite at tag-cut time
(.github/workflows/fern-docs.yml) will produce immutable, working URLs in
the published v1.2.0 docs, since each path exists on the v1.2.0 tag.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NVSkills CI (added in #9998, vendored from
NVIDIA/skillsupstream) dispatches on PR changes underskills/,team-skills/,rules/team-rules/, orplugins/. Pre-flip, Dynamo's canonical skill location was.agents/skills/with a root-levelskillssymlink pointing into it. PRs touching skills showed up under.agents/skills/...in the GitHub PR files API, so the NVSkills path filter never matched and the/nvskills-cisigning dispatch was effectively unreachable.This PR flips the layout:
skills/(real directory at repo root) is now canonical..agents/skillsbecomes a symlink to../skills, preserving the agentskills.io interop convention for clients that walk.agents/skills/natively (Cursor, Codex, etc)..github/filters.yamldrops the now-redundant root-level'skills'entry —.agents/**still covers the new symlink, and skill content underskills/correctly stays outside the docs filter..gitignorenegation pattern updated so the new.agents/skillssymlink is not ignored.Single source of truth on disk; both
skills/<x>/SKILL.mdand.agents/skills/<x>/SKILL.mdresolve to the same content. Clients on either convention keep working.The four skills from #9782 (
dynamo-recipe-runner,dynamo-router-starter,dynamo-troubleshoot,dynamo-interconnect-check) are unmodified in content — only their canonical paths move.Why now
#9782 landed the four Computex bring-up skills under
.agents/skills/. #9998 landed the NVSkills CI dispatch workflow. The two are intended to compose: skills land, get signed. The path-prefix mismatch breaks that composition. This PR is the smallest change that connects them.After merge, a
/nvskills-cicomment on this PR (or any future PR touchingskills/) will dispatch the NVSkills validation + signature attachment flow.Test plan
ls skills/andls .agents/skills/both show the four skill directoriesreadlink .agents/skillsreturns../skills/nvskills-cicomment on this PR dispatches toNVIDIA/nvskills-ci(i.e. confirms the path-filter now matches)🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes