Skip to content

docs: deprecate standalone EPP - #10001

Merged
atchernych merged 1 commit into
mainfrom
DYNO-12-dep
May 27, 2026
Merged

docs: deprecate standalone EPP#10001
atchernych merged 1 commit into
mainfrom
DYNO-12-dep

Conversation

@atchernych

@atchernych atchernych commented May 27, 2026

Copy link
Copy Markdown
Contributor

Overview:

Fixes [DYNO-12] https://linear.app/nvidia/issue/c/fix-6-deprecate-the-standalone-epp-path

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Open in Devin Review

Summary by CodeRabbit

  • Chores

    • Migrated gateway component references from kgateway to agentgateway in CI/CD pipeline.
    • Removed deprecated wrapper script for gateway CRD installation.
    • Removed standalone Helm chart and associated configuration templates for the Endpoint Picker component.
    • Removed sample deployment configuration file.
  • Documentation

    • Simplified deployment guidance by removing references to operator-managed component deployment.

Review Change Stack

Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
@atchernych
atchernych requested review from a team as code owners May 27, 2026 01:02
@github-actions github-actions Bot added docs documentation Improvements or additions to documentation actions labels May 27, 2026
@atchernych
atchernych enabled auto-merge (squash) May 27, 2026 01:04
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 84120a94-5647-497f-b8e4-61d6884e2c1d

📥 Commits

Reviewing files that changed from the base of the PR and between a29f77f and d9b71ff.

📒 Files selected for processing (17)
  • .github/workflows/post-merge-ci.yml
  • deploy/inference-gateway/scripts/install_gaie_crd_kgateway.sh
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/.helmignore
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/Chart.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/epp-config-dynamo.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/NOTES.txt
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/_helpers.tpl
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/cluster-role-binding.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/cluster-role.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/dynamo-epp.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/epp-configmap.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/http-router.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/inference-pool.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/service.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/values.yaml
  • deploy/inference-gateway/standalone/vllm_agg_qwen.yaml
  • docs/kubernetes/inference-gateway.md
💤 Files with no reviewable changes (15)
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/Chart.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/cluster-role-binding.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/epp-configmap.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/.helmignore
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/http-router.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/epp-config-dynamo.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/cluster-role.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/_helpers.tpl
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/values.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/service.yaml
  • deploy/inference-gateway/scripts/install_gaie_crd_kgateway.sh
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/inference-pool.yaml
  • deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/dynamo-epp.yaml
  • deploy/inference-gateway/standalone/vllm_agg_qwen.yaml
  • docs/kubernetes/inference-gateway.md

Walkthrough

This PR removes the standalone dynamo-gaie Helm chart in favor of using agentgateway-managed components, updates the CI workflow to install agentgateway prerequisites instead of kgateway, and streamlines deployment documentation to reflect the simplified architecture.

Changes

dynamo-gaie Helm chart removal and agentgateway transition

Layer / File(s) Summary
CI workflow update to agentgateway
.github/workflows/post-merge-ci.yml
The post-merge CI job's GAIE prerequisites installation step is updated to reference agentgateway components and the corresponding install_gaie_crd_agentgateway.sh script instead of the kgateway equivalents.
Helm chart cleanup and removal
deploy/inference-gateway/standalone/helm/dynamo-gaie/.helmignore, deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/epp-configmap.yaml, deploy/inference-gateway/standalone/helm/dynamo-gaie/templates/http-router.yaml
The dynamo-gaie Helm chart configuration is removed, including the .helmignore patterns file, the epp-configmap template, and the http-router template, along with associated Kubernetes manifests and values.
Documentation cleanup for deployment guidance
docs/kubernetes/inference-gateway.md
Documentation is streamlined to remove references to standalone Dynamo operator-managed deployment patterns and namespace override notes specific to standalone installations, while keeping core deployment instructions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description follows the template structure but lacks substantive details. The 'Details' section is empty, 'Where should the reviewer start?' is empty, and the Related Issues section contains a placeholder (#xxx) rather than actual GitHub issue numbers. Fill in the 'Details' section with a summary of what was removed (Helm charts, deployment scripts, docs sections), and specify in 'Where should the reviewer start?' which files are most critical to review.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs: deprecate standalone EPP' is specific and directly related to the main changes in the PR, which involve removing Helm charts, deployment scripts, and documentation guidance for standalone EPP deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@atchernych
atchernych merged commit 1b0a003 into main May 27, 2026
101 checks passed
@atchernych
atchernych deleted the DYNO-12-dep branch May 27, 2026 22:57
MartinRepo pushed a commit to MartinRepo/dynamo that referenced this pull request May 28, 2026
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
tanmayv25 added a commit that referenced this pull request May 28, 2026
The standalone EPP helm chart was removed in #10001 (docs: deprecate
standalone EPP), but two references to the now-deleted
`deploy/inference-gateway/standalone/helm/dynamo-gaie/epp-config-dynamo.yaml`
file were left behind in docs/kubernetes/inference-gateway.md. Lychee
fails the broken-link check on those (404 from github.com).

Update both lines to point at the recipe-based GAIE configs that the
same doc already mentions as the canonical alternative
(`recipes/llama-3-70b/vllm/{agg,disagg-single-node}/gaie/`), and remove
the "standalone" framing that no longer applies. Drive-by fix to unblock
this PR's CI from a pre-existing broken-link failure on main; the same
fix is needed on main regardless of this PR.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
saturley-hall added a commit that referenced this pull request May 29, 2026
Lychee surfaced three more 404s after the prior fix because the referenced
paths no longer exist on main:

- benchmarks/llm/perf.sh was renamed to benchmarks/frontend/scripts/run_perf.sh
- deploy/inference-gateway/standalone/helm/dynamo-gaie/ was removed when the
  standalone EPP chart was deprecated (PR #10001)

The files do exist on this release branch, so pin the three URLs to
release/1.2.0. This is also semantically correct since the surrounding docs
describe v1.2.0 behavior.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
saturley-hall added a commit that referenced this pull request May 29, 2026
Lychee fails on this release branch because three doc URLs reference
paths that no longer exist at blob/main:

- benchmarks/llm/perf.sh (renamed to benchmarks/frontend/scripts/run_perf.sh)
- deploy/inference-gateway/standalone/helm/dynamo-gaie/ (removed when the
  standalone EPP chart was deprecated, PR #10001)

Adding the URLs to .lycheeignore keeps lychee green on the release branch
while letting Fern's existing blob/main → blob/vX.Y.Z rewrite (in
.github/workflows/fern-docs.yml) produce immutable, working URLs in the
published v1.2.0 docs at tag-cut time. The v1.2.0 tag (built from this
branch) carries all three files at the referenced paths.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
saturley-hall added a commit that referenced this pull request May 29, 2026
Five doc URLs reference paths that no longer exist at blob/main but DO
exist on this release branch (and therefore on the v1.2.0 tag built from
it):

- .agents/skills/{dynamo-docs,tool-parser-generator}/SKILL.md (renamed to
  .agents/contributor-skills/ on main, PR #10017)
- benchmarks/llm/perf.sh (renamed to benchmarks/frontend/scripts/ on main)
- deploy/inference-gateway/standalone/helm/dynamo-gaie/ (removed when the
  standalone EPP chart was deprecated, PR #10001)

Adding them to .lycheeignore keeps lychee CI green on the release branch.
Fern's existing blob/main → blob/vX.Y.Z rewrite at tag-cut time
(.github/workflows/fern-docs.yml) will produce immutable, working URLs in
the published v1.2.0 docs, since each path exists on the v1.2.0 tag.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tmonty12 pushed a commit that referenced this pull request Jun 8, 2026
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions docs documentation Improvements or additions to documentation size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants