docs: deprecate standalone EPP - #10001
Conversation
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
💤 Files with no reviewable changes (15)
WalkthroughThis PR removes the standalone dynamo-gaie Helm chart in favor of using agentgateway-managed components, updates the CI workflow to install agentgateway prerequisites instead of kgateway, and streamlines deployment documentation to reflect the simplified architecture. Changesdynamo-gaie Helm chart removal and agentgateway transition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
The standalone EPP helm chart was removed in #10001 (docs: deprecate standalone EPP), but two references to the now-deleted `deploy/inference-gateway/standalone/helm/dynamo-gaie/epp-config-dynamo.yaml` file were left behind in docs/kubernetes/inference-gateway.md. Lychee fails the broken-link check on those (404 from github.com). Update both lines to point at the recipe-based GAIE configs that the same doc already mentions as the canonical alternative (`recipes/llama-3-70b/vllm/{agg,disagg-single-node}/gaie/`), and remove the "standalone" framing that no longer applies. Drive-by fix to unblock this PR's CI from a pre-existing broken-link failure on main; the same fix is needed on main regardless of this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Lychee surfaced three more 404s after the prior fix because the referenced paths no longer exist on main: - benchmarks/llm/perf.sh was renamed to benchmarks/frontend/scripts/run_perf.sh - deploy/inference-gateway/standalone/helm/dynamo-gaie/ was removed when the standalone EPP chart was deprecated (PR #10001) The files do exist on this release branch, so pin the three URLs to release/1.2.0. This is also semantically correct since the surrounding docs describe v1.2.0 behavior. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Lychee fails on this release branch because three doc URLs reference paths that no longer exist at blob/main: - benchmarks/llm/perf.sh (renamed to benchmarks/frontend/scripts/run_perf.sh) - deploy/inference-gateway/standalone/helm/dynamo-gaie/ (removed when the standalone EPP chart was deprecated, PR #10001) Adding the URLs to .lycheeignore keeps lychee green on the release branch while letting Fern's existing blob/main → blob/vX.Y.Z rewrite (in .github/workflows/fern-docs.yml) produce immutable, working URLs in the published v1.2.0 docs at tag-cut time. The v1.2.0 tag (built from this branch) carries all three files at the referenced paths. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Five doc URLs reference paths that no longer exist at blob/main but DO
exist on this release branch (and therefore on the v1.2.0 tag built from
it):
- .agents/skills/{dynamo-docs,tool-parser-generator}/SKILL.md (renamed to
.agents/contributor-skills/ on main, PR #10017)
- benchmarks/llm/perf.sh (renamed to benchmarks/frontend/scripts/ on main)
- deploy/inference-gateway/standalone/helm/dynamo-gaie/ (removed when the
standalone EPP chart was deprecated, PR #10001)
Adding them to .lycheeignore keeps lychee CI green on the release branch.
Fern's existing blob/main → blob/vX.Y.Z rewrite at tag-cut time
(.github/workflows/fern-docs.yml) will produce immutable, working URLs in
the published v1.2.0 docs, since each path exists on the v1.2.0 tag.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Overview:
Fixes [DYNO-12] https://linear.app/nvidia/issue/c/fix-6-deprecate-the-standalone-epp-path
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Chores
Documentation