chore(ci): rename NVSkills request workflow to match upstream policy - #10024
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates the display name of the NVSkills CI workflow from ChangesWorkflow Display Name Update
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NVIDIA/nvskills-ci's onboarded-repositories.json policy expects request workflows at the canonical path .github/workflows/request-nvskills-ci.yml. PR #9998 landed our wrapper as .github/workflows/nvskills-ci.yml, which collides with the destination workflow's name and is rejected by the downstream validator with: Request workflow path '.github/workflows/nvskills-ci.yml' is not allowed Rename the wrapper to request-nvskills-ci.yml and update the in-workflow 'name:' from "NVSkills CI" to "Request NVSkills CI" — matches the upstream template at NVIDIA/nvskills-ci/templates/team-request-workflow.yml and disambiguates from the validation workflow on the other side. No behavior change. Same triggers, same secret, same callee. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Dan Gil <dagil@nvidia.com>
b8c50b3 to
9fa2ac0
Compare
…i-dynamo#10024) Signed-off-by: Dan Gil <dagil@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Rename the wrapper workflow from
.github/workflows/nvskills-ci.ymlto.github/workflows/request-nvskills-ci.ymlso it matches the path NVIDIA/nvskills-ci's onboarded-repositories policy expects:Also updates the in-workflow
name:fromNVSkills CItoRequest NVSkills CI, aligning with the upstream template atNVIDIA/nvskills-ci/templates/team-request-workflow.ymland disambiguating from the destination repo's ownNVSkills CIworkflow.Why
PR #9998 landed the wrapper as
nvskills-ci.yml. When triggered with/nvskills-cion a PR, the downstream NVIDIA/nvskills-ci validator currently rejects the dispatch:Verified on NVIDIA/nvskills-ci run
26494086764triggered from PR #10017. After this rename, the path matches the policy and signing requests will proceed to validation.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit