Skip to content

chore(ci): rename NVSkills request workflow to match upstream policy - #10024

Merged
saturley-hall merged 1 commit into
mainfrom
chore/rename-nvskills-request-workflow
May 27, 2026
Merged

chore(ci): rename NVSkills request workflow to match upstream policy#10024
saturley-hall merged 1 commit into
mainfrom
chore/rename-nvskills-request-workflow

Conversation

@dagil-nvidia

@dagil-nvidia dagil-nvidia commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Rename the wrapper workflow from .github/workflows/nvskills-ci.yml to .github/workflows/request-nvskills-ci.yml so it matches the path NVIDIA/nvskills-ci's onboarded-repositories policy expects:

"allowed_request_workflow_paths": [".github/workflows/request-nvskills-ci.yml"]

Also updates the in-workflow name: from NVSkills CI to Request NVSkills CI, aligning with the upstream template at NVIDIA/nvskills-ci/templates/team-request-workflow.yml and disambiguating from the destination repo's own NVSkills CI workflow.

Why

PR #9998 landed the wrapper as nvskills-ci.yml. When triggered with /nvskills-ci on a PR, the downstream NVIDIA/nvskills-ci validator currently rejects the dispatch:

Request rejected: Request workflow path '.github/workflows/nvskills-ci.yml' is not allowed

Verified on NVIDIA/nvskills-ci run 26494086764 triggered from PR #10017. After this rename, the path matches the policy and signing requests will proceed to validation.

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow display name.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 02189d4c-5b3e-4591-9fcd-af0729bf3330

📥 Commits

Reviewing files that changed from the base of the PR and between 738300c and b8c50b3.

📒 Files selected for processing (1)
  • .github/workflows/request-nvskills-ci.yml

Walkthrough

This PR updates the display name of the NVSkills CI workflow from NVSkills CI to Request NVSkills CI. The change affects only the workflow's name field in the GitHub Actions configuration, providing clearer labeling of the workflow's trigger purpose.

Changes

Workflow Display Name Update

Layer / File(s) Summary
Workflow display name update
.github/workflows/request-nvskills-ci.yml
The workflow name field was updated from NVSkills CI to Request NVSkills CI to clarify its purpose as a request-triggered workflow.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: renaming the NVSkills workflow to match upstream policy requirements.
Description check ✅ Passed The description covers all required sections from the template with clear details on what changed, why it was needed, and the test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

NVIDIA/nvskills-ci's onboarded-repositories.json policy expects request
workflows at the canonical path .github/workflows/request-nvskills-ci.yml.
PR #9998 landed our wrapper as .github/workflows/nvskills-ci.yml, which
collides with the destination workflow's name and is rejected by the
downstream validator with:

    Request workflow path '.github/workflows/nvskills-ci.yml' is not allowed

Rename the wrapper to request-nvskills-ci.yml and update the in-workflow
'name:' from "NVSkills CI" to "Request NVSkills CI" — matches the upstream
template at NVIDIA/nvskills-ci/templates/team-request-workflow.yml and
disambiguates from the validation workflow on the other side.

No behavior change. Same triggers, same secret, same callee.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Dan Gil <dagil@nvidia.com>
@dagil-nvidia
dagil-nvidia force-pushed the chore/rename-nvskills-request-workflow branch from b8c50b3 to 9fa2ac0 Compare May 27, 2026 08:19
@saturley-hall
saturley-hall merged commit 1804e9f into main May 27, 2026
76 of 83 checks passed
@saturley-hall
saturley-hall deleted the chore/rename-nvskills-request-workflow branch May 27, 2026 13:29
MartinRepo pushed a commit to MartinRepo/dynamo that referenced this pull request May 28, 2026
…i-dynamo#10024)

Signed-off-by: Dan Gil <dagil@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants