chore(skills): add tags frontmatter to four bring-up skills - #10069
Merged
Conversation
github-actions
Bot
added
chore
documentation
Collaborator
Author
|
/nvskills-ci |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughFour skill definition files are updated with YAML front-matter ChangesSkill metadata tagging
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Collaborator
Author
|
/nvskills-ci |
Collaborator
Author
|
/nvskills-ci |
Collaborator
Author
|
/nvskills-ci |
Touches each of the four skills under skills/ to add agentskills.io-compatible 'tags' fields. Matches the convention used by the NVIDIA/nvskills-ci reference skill (skills/ci-smoke-test/SKILL.md). Primary purpose: re-trigger the NVSkills CI validation flow that was first exercised on PR #10017 (now merged). That dispatch reached the downstream GitLab pipeline 52784444 but failed at validate:content with no per-skill detail in the GitHub-side log. This PR re-runs the path so the GitLab validate:content log is fresh and inspectable, and adds a frontmatter field that may be the underlying validation gap. No content changes; SKILL.md bodies, references, scripts, and evals are unmodified. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Dan Gil <dagil@nvidia.com>
…kills NVSkills CI validate:content rejected the four skills because they lack a license declaration in frontmatter. Add 'license: Apache-2.0' to each SKILL.md. Existing per-file SPDX headers are unchanged (SKILL.md / references/*.md remain CC-BY-4.0 for skill content; scripts/*.py remain Apache-2.0 for code). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Dan Gil <dagil@nvidia.com>
Signed-off-by: Dan Gil <dagil@nvidia.com>
…kills
NV-BASE 2.12.0 validation returned 16 issues per skill (1 critical LICENSE,
7 medium SCHEMA/QUALITY, 8 low). LICENSE was fixed in the previous commit;
this commit addresses the rest.
Frontmatter restructure (all four):
- Move 'tags' under 'metadata' (SKILL_SPEC location for recommended fields)
- Add 'metadata.author' (Dan Gil <dagil@nvidia.com>)
- recipe-runner: add 'metadata.permissions' (file_read, network, kubectl_exec)
per the LP3 security finding on that skill
SKILL.md body additions (all four):
- '## Goal' -> '## Purpose' (QUALITY discoverability)
- '## Workflow' -> '## Instructions' (SCHEMA recommended section)
- Add '## Prerequisites' (QUALITY reliability)
- Add '## Available Scripts' with the | Script | Purpose | Arguments | table
the validator expects (QUALITY correctness)
- Add '## Examples' block referencing the run_script() agent protocol
- Add '## Limitations' (QUALITY reliability)
- Add '## Troubleshooting' (QUALITY reliability)
Script lint fixes:
- Add '#!/usr/bin/env python3' shebang and set the executable bit on all four
- Extract magic numbers to module-level named constants in three scripts:
- check_router_health.py: DEFAULT_HTTP_TIMEOUT_SEC, DEFAULT_RETRIES,
DEFAULT_RETRY_SLEEP_SEC, DEFAULT_MAX_TOKENS, HTTP_OK, EXIT_* codes
- collect_dynamo_debug_bundle.py: DEFAULT_KUBECTL_TIMEOUT_SEC,
DEFAULT_LOG_TAIL_LINES, RETURNCODE_COMMAND_NOT_FOUND, RETURNCODE_TIMED_OUT
- check_interconnect.py: DEFAULT_PROBE_TIMEOUT_SEC, RETURNCODE_COMMAND_NOT_FOUND
Description trimming (221-286 chars; validator recommends 50-150) is
intentionally NOT in this commit; long-form trigger keywords are load-bearing
for skill-routing accuracy.
py_compile clean on all four scripts; YAML frontmatter parses on all four
SKILL.md files.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Dan Gil <dagil@nvidia.com>
Signed-off-by: Dan Gil <dagil@nvidia.com>
dagil-nvidia
force-pushed
the
chore/nvskills-trigger-validation
branch
from
May 28, 2026 02:38
b5b9f88 to
35c5a10
Compare
dagil-nvidia
enabled auto-merge (squash)
May 28, 2026 02:38
dagil-nvidia
disabled auto-merge
May 28, 2026 02:49
This was referenced May 28, 2026
tmonty12
pushed a commit
that referenced
this pull request
Jun 8, 2026
Signed-off-by: Dan Gil <dagil@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an agentskills.io-compatible `tags:` field to each of the four bring-up skills under `skills/`. Matches the convention used by the reference `NVIDIA/nvskills-ci/skills/ci-smoke-test/SKILL.md`. No body, references, scripts, or evals changed.
Why
PR #10017 (merged) triggered the NVSkills CI signing flow end-to-end for the first time. The downstream GitLab pipeline (52784444) reached `validate:content` and failed there, with no per-skill error message surfaced back to the GitHub run. Signing was skipped as a result.
This PR:
If `tags` was the issue, this PR clears `validate:content` and the bot attaches signatures. If not, the fresh GitLab log gives the actual diagnostic.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit