[Forwardport] Fix \Magento\Customer\Model\Customer\NotificationStorage class#16
Closed
adrian-martinez-interactiv4 wants to merge 298 commits into2.3-developfrom
Closed
[Forwardport] Fix \Magento\Customer\Model\Customer\NotificationStorage class#16adrian-martinez-interactiv4 wants to merge 298 commits into2.3-developfrom
adrian-martinez-interactiv4 wants to merge 298 commits into2.3-developfrom
Conversation
…er components list
…er components list
…P's upload_max_filesize Add ImageTest coverage for maxFileSize fix
…P's upload_max_filesize Null coalesce to zero if maxFileSize is null
…tual product (gift card)
Fix directive parsing and trailing forward slash issues
Apply changes to tinymce3Adapter.js
…override customer group_id and store_id
…lying an extra cent to the discount amount for
…o2ce into MAGETWO-70886-magento-magento2-9347
- Fixes based on static tests
…override customer group_id and store_id
…tual product (gift card)
…AGETWO-90177-Image-Broken-on-Storefront-with-Secure-Key
…er components list
…lying an extra cent to the discount amount for
…e shows "Your credit card will be charged for" magento#993
…n getPaymentMethodList magento#15134 - Merge Pull Request magento#15134 from mzeis/magento2:2.3-develop-PR-port-15032 - Merged commits: 1. 971e303
…182-Bundle-Child-Index [Honey-Badgers] Bug Fixes
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#9347: Zend feed refactoring (by @ldusan84) - magento#15154: [Forwardport] Fixed documentation about viewModels (by @dmytro-ch) - magento#15143: [Forwardport] chore: checkout last 5 commits (by @mzeis) - magento#15123: [Forwardport] small optimization in if-condition (by @mzeis) - magento#15071: [Forwardport] Add statement to 'beforeSave' method to allow app:config:import (by @adrian-martinez-interactiv4) - magento#15070: [Forwardport] Duplicate Order Confirmation Emails for PayPal Express checkout order (by @adrian-martinez-interactiv4) - magento#15063: [2.3-develop][Forwardport] magento#7822 Empty Checkout Agreement Edit Form when Single Store Mode is enabled (by @gwharton) - magento#14429: [ForwardPort 2.3-develop] Fix \Magento\Checkout\Controller\Index\Index::isSecureRequest method to take care of current request being secure and also from referer, as stated in phpdoc block (by @adrian-martinez-interactiv4) Fixed GitHub Issues: - magento#9240: Upgrade ZF components. Zend_Feed (reported by @okorshenko) has been fixed in magento#9347 by @ldusan84 in 2.3-develop branch Related commits: 1. ca9e582 2. ed33b18 3. c7ba65a 4. 9d0a290 5. 109047f 6. 4534a2e 7. c413389 8. caa4471 9. 66154e6 10. 49bcf98 11. c0b4c7a 12. 411d0fc 13. 9779ebe 14. eba92d0 15. 983d74f 16. 0b51e8c 17. 74d431a 18. 7f73d67 19. 2933223 20. 64610d3 21. d2d397a 22. 0770227 23. 735c840 24. 7e17d20 25. 46c51ba 26. 3a3683f 27. 6311d5c 28. 4462eaf - magento#7822: Empty Checkout Agreement Edit Form when Single Store Mode is enabled (reported by @RedEnzian) has been fixed in magento#15063 by @gwharton in 2.3-develop branch Related commits: 1. d61fe1d 2. 9c4a26f 3. 76be1b9 - magento#4301: Hit fast twice F5 on checout page, customer loggs out automatically (reported by @daniel-ifrim) has been fixed in magento#14429 by @adrian-martinez-interactiv4 in 2.3-develop branch Related commits: 1. f82a175 2. 4d23b8b - magento#12362: Concurrent (quick reload) requests on checkout cause cart to empty - related to session_regenerate_id (reported by @minlare) has been fixed in magento#14429 by @adrian-martinez-interactiv4 in 2.3-develop branch Related commits: 1. f82a175 2. 4d23b8b - magento#13427: [2.1.11] Add to cart, try to checkout, cart is empty but mini-cart has items. (reported by @aeu) has been fixed in magento#14429 by @adrian-martinez-interactiv4 in 2.3-develop branch Related commits: 1. f82a175 2. 4d23b8b
…n getPaymentMethodList magento#15134
…to store ipv6 addresses magento#15142
…setting to represent what it actually does magento#15080
…min cart price rule edit page for user which has no access to CatalogRule module magento#15074
…ipt wasn't loaded correctly because of network error magento#15072
Accepted Public Pull Requests: - magento#15134: [Forwardport] [TASK] Fix overriding of payment methods in getPaymentMethodList (by @mzeis) - magento#15142: [Forwardport] Changed the length of the remote_ip field to store ipv6 addresses (by @dmytro-ch) - magento#15095: [Forwardport] Fix reset password link with appropriate customer store (by @rogyar) - magento#15080: [Forwardport] Renamed "Add Block Names to Hints" config setting to represent what it actually does (by @adrian-martinez-interactiv4) - magento#15079: [Forwardport] Change 'Update'-button visibility on change qty event. (by @adrian-martinez-interactiv4) - magento#15074: [Forwardport] Fixed issue products grid operations in admin cart price rule edit page for user which has no access to CatalogRule module (by @adrian-martinez-interactiv4) - magento#15077: [Forwardport] FIX for issue#14855 - Adding an * to do a customer search (by @adrian-martinez-interactiv4) - magento#15072: [Forwardport] Fix infinite checkout loader when some script wasn't loaded correctly because of network error (by @adrian-martinez-interactiv4) Fixed GitHub Issues: - magento#13460: Allmethods config source model does not always report the full list of payment methods (reported by @moehrenzahn) has been fixed in magento#15134 by @mzeis in 2.3-develop branch Related commits: 1. 971e303 - magento#10395: REMOTE_IP gets saved partially when using IPV6 (reported by @keevitaja) has been fixed in magento#15142 by @dmytro-ch in 2.3-develop branch Related commits: 1. 41a99e1 - magento#5726: Reset Password Email Issue on Multi Store from Admin (reported by @ngashokkumar) has been fixed in magento#15095 by @rogyar in 2.3-develop branch Related commits: 1. 1e8ce46 2. a267e2f 3. 407c930 - magento#14855: Adding an * to do a customer search. (reported by @taylored2) has been fixed in magento#15077 by @adrian-martinez-interactiv4 in 2.3-develop branch Related commits: 1. 01b546f
[pangolin] RE-develop functional tests
- merged latest code from mainline branch
[TSG] Upporting for 2.3 (pr18) (2.3.0)
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#15128: [Forwardport] chore: use random_int() in some places (by @mzeis)
…move deprecated private method getSerializer, injected in constructor instead
adrian-martinez-interactiv4
force-pushed
the
2.3-develop-PR-port-15262
branch
from
45ae58d to
ed368b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15262
Fix \Magento\Customer\Model\Customer\NotificationStorage class
Description
Removed duplicated phpdoc comment
Fixed class variable phpdoc comment
Removed deprecated private method getSerializer, serializer injected in constructor instead
Fixed Issues (if relevant)
None, improvement.
Manual testing scenarios
None, improvement.
Contribution checklist