[Forwardport] [TASK] Fix overriding of payment methods in getPaymentMethodList #15134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@mzeis Please, revert changes and make force push with the right commit message. |
mzeis
force-pushed
the
2.3-develop-PR-port-15032
branch
from
3243096 to
971e303
Compare
|
Thanks @rogyar for catching this and sorry for the confusion. This was caused by a stupid copy & paste mistake. @VladimirZaets this should be correct now, hopefully. |
magento-engcom-team
pushed a commit
that referenced
this pull request
May 12, 2018
…n getPaymentMethodList #15134
|
Hi @mzeis. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15032
Fixes Issue #13460, keeps changes from pull request #12284
Description
This fix only sets the value of a group if it doesn't already exist when calling \Magento\Payment\Helper\Data::getPaymentMethodList with parameter $withGroups = true.
Fixed Issues
#13460
#12284
Manual testing scenarios