Skip to content

[Forwardport] small optimization in if-condition#15123

Merged
magento-engcom-team merged 6 commits intomagento:2.3-developfrom
mzeis:2.3-develop-PR-port-15002
May 12, 2018
Merged

[Forwardport] small optimization in if-condition#15123
magento-engcom-team merged 6 commits intomagento:2.3-developfrom
mzeis:2.3-develop-PR-port-15002

Conversation

@mzeis
Copy link
Copy Markdown
Contributor

@mzeis mzeis commented May 10, 2018

Original Pull Request

#15002

Description

There is no needs to cast $value to bool in runtime because it have value === '' by if-condition above

Fixed Issues (if relevant)

Not relevant.

Manual testing scenarios

Not relevant.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@mzeis thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @mzeis. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants