Proposed 2.3.0-b4 #5144
Merged
Proposed 2.3.0-b4 #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add fixNFTokenPageLinks amendment: It was discovered that under rare circumstances the links between NFTokenPages could be removed. If this happens, then the account_objects and account_nfts RPC commands under-report the NFTokens owned by an account. The fixNFTokenPageLinks amendment does the following to address the problem: - It fixes the underlying problem so no further broken links should be created. - It adds Invariants so, if such damage were introduced in the future, an invariant would stop it. - It adds a new FixLedgerState transaction that repairs directories that were damaged in this fashion. - It adds unit tests for all of it.
Implements a CI workflow that detects when a new version of libxrpl is proposed, uploads it to artifactory under the `clio` channel and notifies Clio's CI to check this newly proposed version.
* Add "doxygen" to list of supported branches to allow for testing and development. * Add titles / H1 to some .md files that don't have them.
Co-authored-by: Elliot Lee <[email protected]>
* Log when duplicate concurrent inbound ledger are filtered. * RAII for containers that track concurrent inbound ledger. * Comment on when to asynchronously acquire inbound ledgers, which is possible to be always OK, but should have further review. * Other small logging changes Co-authored-by: Ed Hennis <[email protected]>
* refactor filtering of validations to specifically avoid concurrent checkAccept() calls for the same validation ledger hash. * Log when duplicate concurrent validation requests are filtered. * RAII for containers that track concurrent validation requests.
* upstream/master: Set version to 2.2.2 Allow only 1 job queue slot for each validation ledger check Allow only 1 job queue slot for acquiring inbound ledger. Track latencies of certain code blocks, and log if they take too long
* Retry some failed RPC connections / commands in unit tests * Remove orphaned `getAccounts` function Co-authored-by: John Freeman <[email protected]>
When rippled initiates a connection to SQLite3, rippled sends a "PRAGMA" statement defining the maximum number of pages allowed in the database. Update the max_page_count so it is consistent with the default for newer versions of SQLite3. Increasing max_page_count is critical for keeping full history servers online. Fix #5102
Signed-off-by: luozexuan <[email protected]>
Update book_changes RPC to reduce latency, add "validated" field, and accept shortcut strings (current, closed, validated) for ledger_index. `"validated": true` indicates that the transaction has been included in a validated ledger so the result of the transaction is immutable. Fix #5033 Fix #5034 Fix #5035 Fix #5036 --------- Co-authored-by: Bronek Kozicki <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #5144 +/- ##
=========================================
+ Coverage 71.1% 76.2% +5.1%
=========================================
Files 796 760 -36
Lines 67028 61568 -5460
Branches 10981 8126 -2855
=========================================
- Hits 47660 46909 -751
+ Misses 19368 14659 -4709
... and 1252 files with indirect coverage changes |
|
The page_size will soon be made configurable with #5135, making this re-ordering necessary. When opening SQLite connection, there are specific pragmas set with commonPragmas. In particular, PRAGMA journal_mode creates journal file and locks the page_size; as of this commit, this sets the page size to the default value of 4096. Coincidentally, the hardcoded page_size was also 4096, so no issue was noticed.
Make page_size and journal_size_limit configurable values in rippled.cfg
intelliot
force-pushed
the
release-next
branch
from
5e41723 to
1fbf8da
Compare
|
Rebased on latest |
Bronek
approved these changes
Sep 23, 2024
| @@ -6,6 +6,173 @@ This document contains the release notes for `rippled`, the reference server imp | |||
|
|
|||
| Have new ideas? Need help with setting up your node? [Please open an issue here](https://github.com/xrplf/rippled/issues/new/choose). | |||
|
|
|||
| # Version 2.2.3 | |||
There was a problem hiding this comment.
We will eventually need to add 2.3 section where we mention
- refactoring which affects projects with dependencies on this project
- removal of reporting mode
- removal of shards support
Not sure where we put the list of new amendments ?
featureNFTokenMintOffer
fixReducedOffersV2
fixEnforceNFTokenTrustline
fixInnerObjTemplate2
featureInvariantsV1_1
fixNFTokenPageLinks
This can wait until release candidate, so just mentioning with no change requested.
There was a problem hiding this comment.
Yes, I think the new amendments should be listed here under a new 2.3 section, in addition to being added on https://xrpl.org/resources/known-amendments which is the page I most frequently reference when it comes to amendments.
Those sound like breaking changes; I wonder if it's time for rippled 3.0 😀
Though now that there is Clio, I doubt anyone uses Reporting Mode anymore; I suppose 2.3 is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This is a beta for the 2.3.0 release.
This differs from #5141 in 2 ways:
developThe base branch is
release. All releases (including betas) go inrelease. This PR will be merged with--ff-only(not squashed or rebased, and not using the GitHub UI) to bothreleaseanddevelop.Context of Change
This beta includes the hotfix that was included in 2.2.3. There are also other changes; please review the commits associated with this PR to see what has changed since 2.3.0-b2.
Type of Change