Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Factor out Transactor::trapTransaction #5087

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Aug 2, 2024

High Level Overview of Change

A more convenient location to set a breakpoint when replaying transactions.

Context of Change

This is a follow-up to #5027 , suggested by @ximinez

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@Bronek Bronek added the Trivial label Aug 2, 2024
@Bronek Bronek requested a review from ximinez August 2, 2024 12:52
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8%. Comparing base (7d27b11) to head (43b9c6e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5087     +/-   ##
=========================================
- Coverage     74.8%   74.8%   -0.0%     
=========================================
  Files          766     766             
  Lines        63002   63004      +2     
  Branches      8839    8839             
=========================================
- Hits         47144   47142      -2     
- Misses       15858   15862      +4     
Files Coverage Δ
src/xrpld/app/tx/detail/Transactor.cpp 84.7% <100.0%> (+0.1%) ⬆️
src/xrpld/app/tx/detail/Transactor.h 100.0% <ø> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

@ximinez ximinez added Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. and removed Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. labels Aug 2, 2024
@Bronek Bronek added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 3, 2024
@ximinez ximinez merged commit 0a331ea into XRPLF:develop Aug 5, 2024
19 of 20 checks passed
vlntb pushed a commit to vlntb/rippled that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants