Retry RPC commands to try to fix MacOS CI jobs #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geared toward fixing MacOS test run failures
ximinez
added
CI
ximinez
added
the
Passed
* upstream/develop: Update Release Notes for 2.2.1 and 2.2.2 Set version to 2.2.2 Allow only 1 job queue slot for each validation ledger check Allow only 1 job queue slot for acquiring inbound ledger. Track latencies of certain code blocks, and log if they take too long
thejohnfreeman
requested changes
Sep 11, 2024
Co-authored-by: John Freeman <[email protected]>
ximinez
removed
the
Passed
thejohnfreeman
approved these changes
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5120 +/- ##
=======================================
Coverage 76.1% 76.1%
=======================================
Files 760 760
Lines 61556 61548 -8
Branches 8167 8159 -8
=======================================
+ Hits 46835 46836 +1
+ Misses 14721 14712 -9
... and 3 files with indirect coverage changes |
ximinez
added
the
Passed
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Oct 30, 2024
* Follow up to XRPLF#5120 (23991c9), which added a retry for submit commands. It improved MacOS test reliability, but other tests are failing now. * Retry all failed RPC connections / commands in unit tests.
2 tasks
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Oct 30, 2024
* Follow up to XRPLF#5120 (23991c9), which added a retry for submit commands. It improved MacOS test reliability, but other tests are failing now. * Retry all failed RPC connections / commands in unit tests.
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Oct 31, 2024
* Follow up to XRPLF#5120 (23991c9), which added a retry for submit commands. It improved MacOS test reliability, but other tests are failing now. * Retry all failed RPC connections / commands in unit tests.
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Nov 5, 2024
* Follow up to XRPLF#5120 (23991c9), which added a retry for submit commands. It improved MacOS test reliability, but other tests are failing now. * Retry all failed RPC connections / commands in unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Retries failed RPC connection timeouts up to 3 times, unless the test is expecting a timeout. Geared toward fixing MacOS test run failures.
Also remove an orphaned free function:
getAccounts.Context of Change
MacOS CI jobs have been failing spuriously for a while due to timeouts. This seems to resolve the issue.
Type of Change
API Impact
None