Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead headers #5081

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Remove dead headers #5081

merged 5 commits into from
Aug 28, 2024

Conversation

thejohnfreeman
Copy link
Collaborator

Remove a set of headers included by no files outside of the set.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.2%. Comparing base (4d7aed8) to head (63940f5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5081   +/-   ##
=======================================
  Coverage     76.1%   76.2%           
=======================================
  Files          760     760           
  Lines        61489   61489           
  Branches      8137    8115   -22     
=======================================
+ Hits         46809   46833   +24     
+ Misses       14680   14656   -24     
Files with missing lines Coverage Δ
src/xrpld/peerfinder/detail/Logic.h 47.6% <ø> (ø)

... and 6 files with indirect coverage changes

Impacted file tree graph

@ximinez
Copy link
Collaborator

ximinez commented Jul 30, 2024

Would it be fair to say this PR is "trivial"?

Copy link
Collaborator

@Bronek Bronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thejohnfreeman thejohnfreeman added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 28, 2024
@thejohnfreeman thejohnfreeman merged commit cad8970 into XRPLF:develop Aug 28, 2024
20 checks passed
@thejohnfreeman thejohnfreeman deleted the dead branch August 28, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Remove unused code Trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants