Proposed 2.3.0-b1 #5050
Merged
Proposed 2.3.0-b1 #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RPLF#5027) * Add trap_tx_hash command line option This new option can be used only if replay is also enabled. It takes a transaction hash from the ledger loaded for replay, and will cause a specific line to be hit in Transactor.cpp, right before the selected transaction is applied.
Add missed coma in 'exportes_sources'
…5032) Fixes issue XRPLF#4937. The fixReducedOffersV1 amendment fixed certain forms of offer modification that could lead to blocked order books. Reduced offers can block order books if the effective quality of the reduced offer is worse than the quality of the original offer (from the perspective of the taker). It turns out that, for small values, the quality of the reduced offer can be significantly affected by the rounding mode used during scaling computations. Issue XRPLF#4937 identified an additional code path that modified offers in a way that could lead to blocked order books. This commit changes the rounding in that newly located code path so the quality of the modified offer is never worse than the quality of the offer as it was originally placed. It is possible that additional ways of producing blocking offers will come to light. Therefore there may be a future need for a V3 amendment.
Fix interactions between NFTokenOffers and trust lines. Since the NFTokenAcceptOffer does not check the trust line that the issuer receives as a transfer fee in the NFTokenAcceptOffer, if the issuer deletes the trust line after NFTokenCreateOffer, the trust line is created for the issuer by the NFTokenAcceptOffer. That's fixed. Resolves XRPLF#4925.
* Change order of checks in amm_info * Change amm_info error message in API version 3 * Change amm_info error tests
- Remove CMake module "MultiConfig". - Update clang-format configuration, CodeCov configuration, levelization script. - Replace source lists in CMake with globs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #5050 +/- ##
=========================================
+ Coverage 71.1% 71.3% +0.2%
=========================================
Files 796 796
Lines 66997 66987 -10
Branches 11005 10889 -116
=========================================
+ Hits 47639 47761 +122
+ Misses 19358 19226 -132
... and 1260 files with indirect coverage changes |
scottschurr
approved these changes
Jun 20, 2024
legleux
added a commit
to legleux/validator-keys-tool
that referenced
this pull request
Jun 22, 2024
legleux
added a commit
to ripple/validator-keys-tool
that referenced
this pull request
Jun 28, 2024
* Changed required for XRPLF/rippled#5050 * clang-format * Update clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This is a beta for the 2.2.0 release.
Highlights:
The base branch is
release. All releases (including betas) go inrelease. This PR will be merged with--ff-only(not squashed or rebased, and not using the GitHub UI) to bothreleaseanddevelop.Context of Change
This introduces
fixEnforceNFTokenTrustlineamendment to fix interactions between NFTokenOffers and trust lines.featureNFTokenMintOfferamendment to allow creating NFTokenOffer in a NFTokenMint transaction.fixReducedOffersV2amendment to prevent offers from blocking order books.Type of Change
API Impact
No API impact.