Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT issuer is inadvertently creating a trustline due to third-party transactions(Version: 2.1.0) #4925

Closed
tequdev opened this issue Feb 22, 2024 · 5 comments · Fixed by #4946
Closed

NFT issuer is inadvertently creating a trustline due to third-party transactions(Version: 2.1.0) #4925

tequdev opened this issue Feb 22, 2024 · 5 comments · Fixed by #4946
Assignees
@scottschurr

Comments

@tequdev
Copy link
Contributor

tequdev commented Feb 22, 2024 •
edited
Loading

Issue Description

Since the NFTokenAcceptOffer does not check the trust line that the issuer receives as a transfer fee in the NFTokenAcceptOffer, if the issuer deletes the trust line after NFTokenCreateOffer, the trust line is created for the issuer by the NFTokenAcceptOffer.

Steps to Reproduce

  1. Issuer has Trustline (ie: USD)
  2. Mint NFToken with transfer fee
  3. Transfer NFToken to Alice.
  4. Alice create NFTokenOffer to bob with 10 USD
  5. Issuer delete USD Trustline
  6. Accept NFTokenOffer

Expected Result

NFTokenAcceptOffer transaction fails with terNO_LINE

Actual Result

NFTokenAcceptOffer transaction succeeds and a trustline is created for the issuer.

Environment

rippled 2.1.0

Supporting Files

https://gist.github.com/tequdev/f5cfd3f3cfbfcf4a22205052962e6cfe
@ximinez
Copy link
Collaborator

ximinez commented Feb 22, 2024

Do you have any example transaction(s)?

@tequdev
Copy link
Contributor Author

tequdev commented Feb 23, 2024

Do you have any example transaction(s)?

You can find gist code in the supporting files.

@ximinez
Copy link
Collaborator

ximinez commented Feb 26, 2024

Yes, that's the code you used to generate transaction, but what I'm asking for is transaction IDs that have already been validated, and which network they're on.

@tequdev
Copy link
Contributor Author

tequdev commented Feb 27, 2024

This NFTokenAcceptOffer transaction creates a trustline for NFT's Issuer account.

https://testnet.xrpl.org/transactions/DB9EC35BEC75D314CAB5D4ADBF676C0ACE4EF03EAA83268921C377CD0ACF4934/detailed

NFToken issuer account
https://testnet.xrpl.org/accounts/rL4qyVGJLjch4863okbM9brrR5EhFrHZ61

@ximinez
Copy link
Collaborator

ximinez commented Feb 29, 2024 •
edited
Loading

Yep. Confirmed that this is a legitimate issue.

scottschurr added a commit to scottschurr/rippled that referenced this issue Mar 7, 2024
@scottschurr
fixNFTokenTrustlineSurprise amendment:
cd2dcda 
Fix bugs in interactions between NFTokenOffers and trust lines.

Since the NFTokenAcceptOffer does not check the trust line that
the issuer receives as a transfer fee in the NFTokenAcceptOffer,
if the issuer deletes the trust line after NFTokenCreateOffer,
the trust line is created for the issuer by the
NFTokenAcceptOffer.  That's fixed.

Also if Alice issues an IOU and also mints NFTokens with a
transfer fee, Alice's IOU cannot be used to pay for transfers
of those NFTokens.  That's fixed.

Resolves XRPLF#4925.
Resolves XRPLF#4941.
scottschurr added a commit to scottschurr/rippled that referenced this issue Mar 7, 2024
@scottschurr
fixNFTokenTrustlineSurprise amendment:
b6c94a9 
Fix bugs in interactions between NFTokenOffers and trust lines.

Since the NFTokenAcceptOffer does not check the trust line that
the issuer receives as a transfer fee in the NFTokenAcceptOffer,
if the issuer deletes the trust line after NFTokenCreateOffer,
the trust line is created for the issuer by the
NFTokenAcceptOffer.  That's fixed.

Also if Alice issues an IOU and also mints NFTokens with a
transfer fee, Alice's IOU cannot be used to pay for transfers
of those NFTokens.  That's fixed.

Resolves XRPLF#4925.
Resolves XRPLF#4941.
scottschurr added a commit to scottschurr/rippled that referenced this issue Mar 8, 2024
@scottschurr
Add the fixNFTokenTrustlineSurprise amendment:
b40d3fc 
Fix bugs in interactions between NFTokenOffers and trust lines.

Since the NFTokenAcceptOffer does not check the trust line that
the issuer receives as a transfer fee in the NFTokenAcceptOffer,
if the issuer deletes the trust line after NFTokenCreateOffer,
the trust line is created for the issuer by the
NFTokenAcceptOffer.  That's fixed.

Also if Alice issues an IOU and also mints NFTokens with a
transfer fee, Alice's IOU cannot be used to pay for transfers
of those NFTokens.  That's fixed.

Resolves XRPLF#4925.
Resolves XRPLF#4941.
@scottschurr scottschurr mentioned this issue Mar 9, 2024
Merged
2 tasks
scottschurr added a commit to scottschurr/rippled that referenced this issue Jun 17, 2024
@scottschurr
Add the fixEnforceNFTokenTrustline amendment:
d0fef14 
Fix interactions between NFTokenOffers and trust lines.

Since the NFTokenAcceptOffer does not check the trust line that
the issuer receives as a transfer fee in the NFTokenAcceptOffer,
if the issuer deletes the trust line after NFTokenCreateOffer,
the trust line is created for the issuer by the
NFTokenAcceptOffer.  That's fixed.

Resolves XRPLF#4925.
seelabs pushed a commit that referenced this issue Jun 18, 2024
@scottschurr
Add the fixEnforceNFTokenTrustline amendment: (#4946)
223e6c7 
Fix interactions between NFTokenOffers and trust lines.

Since the NFTokenAcceptOffer does not check the trust line that
the issuer receives as a transfer fee in the NFTokenAcceptOffer,
if the issuer deletes the trust line after NFTokenCreateOffer,
the trust line is created for the issuer by the
NFTokenAcceptOffer.  That's fixed.

Resolves #4925.
vlntb pushed a commit to vlntb/rippled that referenced this issue Aug 23, 2024
@scottschurr @vlntb
Add the fixEnforceNFTokenTrustline amendment: (XRPLF#4946)
7efd80a 
Fix interactions between NFTokenOffers and trust lines.

Since the NFTokenAcceptOffer does not check the trust line that
the issuer receives as a transfer fee in the NFTokenAcceptOffer,
if the issuer deletes the trust line after NFTokenCreateOffer,
the trust line is created for the issuer by the
NFTokenAcceptOffer.  That's fixed.

Resolves XRPLF#4925.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottschurr scottschurr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the fixEnforceNFTokenTrustline amendment: scottschurr/rippled
3 participants
@ximinez @scottschurr @tequdev