Fix compatibility with Conan 2.x #5001
Conversation
BUILD.md
Outdated
| @@ -36,7 +36,7 @@ See [System Requirements](https://xrpl.org/system-requirements.html). | |||
| Building rippled generally requires git, Python, Conan, CMake, and a C++ compiler. Some guidance on setting up such a [C++ development environment can be found here](./docs/build/environment.md). | |||
|
|
|||
| - [Python 3.7](https://www.python.org/downloads/) | |||
| - [Conan 1.55](https://conan.io/downloads.html) | |||
| - [Conan 1.60](https://conan.io/downloads.html) | |||
There was a problem hiding this comment.
If you're making this change, but still not recommending >=2.0, maybe add a note to that effect here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5001 +/- ##
=========================================
- Coverage 71.1% 71.1% -0.0%
=========================================
Files 796 796
Lines 66997 66997
Branches 11005 10980 -25
=========================================
- Hits 47639 47633 -6
- Misses 19358 19364 +6 see 4 files with indirect coverage changes |
There was a problem hiding this comment.
I tested it on
- MacOS with apple-clang-15 (and with
-DBOOST_ASIO_DISABLE_CONCEPTSworkaround, moved to bothbuildenvandrunenv) - Linux with clang-17 (also with
-DBOOST_ASIO_DISABLE_CONCEPTSworkaround) - Linux with gcc-12
... and it worked on all three without a hitch. I tried only Debug , but I've also run unit tests just to be sure.
One comment for possible documentation improvement, this aside this is brilliant - thank you !
| which is why we are not recommending it yet. | ||
| Notably, the `conan profile update` command is removed in 2.x. | ||
| Profiles must be edited by hand. | ||
|
|
There was a problem hiding this comment.
This would be a good place to also explain whether runenv or buildenv (or both) should be used instead of env, for the workarounds.
There was a problem hiding this comment.
We should be encouraging the conf.tools settings. Environment variables are frowned upon, but sometimes a necessary backup depending on (a) the Conan version and (b) the Conan generator. As Conan matures, environment variables will stop working and everything will use conf.tools. That said, I'll add a comment about environments in Conan 2.x.
thejohnfreeman
added
the
Passed
This PR makes a few small changes to
conanfile.pythat make it work with Conan 2.x in my basic testing. I don't think we should recommend 2.x yet. It requires a small change to theconan exportinstructions, and theconan profile updateinstructions are completely invalid. Builders will have to manually edit their profiles to make changes. 1.x support is unaffected.Closes #4926, #4990