-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixReducedOffersV1 still not covering all cases and book blocking (Version: 2.1.0) #4937
Comments
@lathanbritz, I'm disappointed but not surprised that I didn't fix all the ways that order books can be blocked. I have something else I'm working on right now, but this issue is next on my list after that's done. It would help a lot if you can identify a specific historic transaction that failed because of this blockage. Of course you can only point at transactions that fail with a |
@scottschurr rLtdxMMXPs21PYnnSiwm85EabdHDH4oVhi has blocked the USD book (its the one with the partially filled order), it does not have too many tx |
@lathanbritz that helps, thanks. That's current? Like that's the state of the book for, say, ledger 86325875? Is there a way you can get the ledger index of the blocking offer (from rLtdxMMXPs21PYnnSiwm85EabdHDH4oVhi). That would be a big help. Then I can look back at that offer's history. |
@scottschurr we have another instance today ledger index 86,858,489 its present here is the offending offer possibly... its left 4 drops behind..
and here is a dump of all the offers.
|
@lathanbritz, thanks for the information on that recent blockage. I have a unit test that is able to reproduce the last blockage that you reported (by When I get an opening I'll research this more recent blockage, since it may not have the same source as the older one that I'm currently looking at. |
@shortthefomo, first the good news: I found the source of the problem for the USD/Bitstamp:XRP blockage that you reported earlier. I have a proposed fix (not yet a pull request), but that will of course need to go through code review. Regarding the reported order book blockage in ledger 86,858,489 I have less good news. I analyzed the top-most 150 offers in the...
order book in that ledger. That included the one you identified with TakerPays: "4" (that was offer 49). I don't see how any of those 150 offers could be blockers. I'm not saying you didn't see something funny with that order book. But I don't understand the nature of the symptom you were seeing. All-in-all, however, it is forward progress to identify an additional source of order book blockage and find a fix for it. Thanks for the help. |
Great news! The symptoms that I see that makes it simple to spot is simply taking the first offers off ASK/BID books and then checking for a negative spread. If it's negative those books (ASK and BID) had an order that is "stuck". That's how ive been identifying them, not sure if that information helps here. If you want we can keep watching for cases, honestly not been looking to hard last while, maybe a few more examples is the right thing to do here and see if that may help shed some further light? or another option is also simply to write a little script that iterates over the different pairs and looks for this negative spread. I don't think it would be to difficult to write something of that nature, see if I can find a gap todo that and then I will share that if you want? |
Fixes issue #4937. The fixReducedOffersV1 amendment fixed certain forms of offer modification that could lead to blocked order books. Reduced offers can block order books if the effective quality of the reduced offer is worse than the quality of the original offer (from the perspective of the taker). It turns out that, for small values, the quality of the reduced offer can be significantly affected by the rounding mode used during scaling computations. Issue #4937 identified an additional code path that modified offers in a way that could lead to blocked order books. This commit changes the rounding in that newly located code path so the quality of the modified offer is never worse than the quality of the offer as it was originally placed. It is possible that additional ways of producing blocking offers will come to light. Therefore there may be a future need for a V3 amendment.
this is expected to be fixed by feel free to re-open this issue if more needs to be done |
…5032) Fixes issue XRPLF#4937. The fixReducedOffersV1 amendment fixed certain forms of offer modification that could lead to blocked order books. Reduced offers can block order books if the effective quality of the reduced offer is worse than the quality of the original offer (from the perspective of the taker). It turns out that, for small values, the quality of the reduced offer can be significantly affected by the rounding mode used during scaling computations. Issue XRPLF#4937 identified an additional code path that modified offers in a way that could lead to blocked order books. This commit changes the rounding in that newly located code path so the quality of the modified offer is never worse than the quality of the offer as it was originally placed. It is possible that additional ways of producing blocking offers will come to light. Therefore there may be a future need for a V3 amendment.
Issue Description
Amendment fixReducedOffersV1 https://xrpl.org/resources/known-amendments#fixreducedoffersv1 is still not fixing all case where the order book is blocked
two cases have now been identified on mainnet.
Supporting Files
The text was updated successfully, but these errors were encountered: