[Block] File: Fix embedded PDF files in Safari #55667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
Browser Issues
luisherranz
approved these changes
Oct 27, 2023
luisherranz
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: -97 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 605a2ef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6670157529
|
|
@DAreRodz, @luisherranz, thanks so much for the quick fix here. 🙇♀️ As this addresses a regression in 6.4, I've gone ahead to cherry-pick it for inclusion in e058ca2. |
SiobhyB
removed
the
Backport to WP 6.7 Beta/RC
SiobhyB
pushed a commit
that referenced
this pull request
Oct 28, 2023
* Patterns: set context of pattern category api call to view so authors and contributors can access (#55553) * Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539) * Update useContainsThirdPartyBlocks and texts * Improve texts a bit * Show the list of unsupported blocks * Use the BlockTitle component instead * Simplify modal text * Revert "Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539)" This reverts commit f2dd6de. * Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539) * Update useContainsThirdPartyBlocks and texts * Improve texts a bit * Show the list of unsupported blocks * Use the BlockTitle component instead * Simplify modal text * Revert CSS changes to show/hide embedded pdf (#55667) * Ensure Term Description block is available in core (#55669) Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active. --------- Co-authored-by: Glen Davies <[email protected]> Co-authored-by: David Arenas <[email protected]>
hellofromtonya
added
the
[Type] Regression
luisherranz
removed
the
[Type] Bug
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: #5587. This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. git-svn-id: https://develop.svn.wordpress.org/trunk@57034 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: WordPress/wordpress-develop#5587. This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. Built from https://develop.svn.wordpress.org/trunk@57034 git-svn-id: http://core.svn.wordpress.org/trunk@56545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: WordPress/wordpress-develop#5587. This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. Built from https://develop.svn.wordpress.org/trunk@57034 git-svn-id: https://core.svn.wordpress.org/trunk@56545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: #5587 This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Reviewed by helloFromTonya. Merges [57034] to the 6.4 branch. Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57035 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: WordPress/wordpress-develop#5587 This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Reviewed by helloFromTonya. Merges [57034] to the 6.4 branch. Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. Built from https://develop.svn.wordpress.org/branches/6.4@57035 git-svn-id: http://core.svn.wordpress.org/branches/6.4@56546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #55493:
Why?
PDF files can not be visualized, even blocking the page and making it appear frozen.
How?
Reverting changes from 1b0c801.
In that commit, we moved from
hiddentodisplay: noneto minimize any potential layout shifts, but it seems that the change wasn't tested in Safari.Reverting this change, the feature works again, although it probably is a bug in Safari instead of something broken in the block's logic.
Testing Instructions
Screen recording
Screen.Recording.2023-10-27.at.19.13.07.mov