Fix: Term Description block should only be available in the site editor #51053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
carolinan
added
[Block] Term Description
|
Flaky tests detected in c988f9d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5265203395
|
aristath
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
This looks good to me! It's a minimal and simple change, fixes the issue, and gets the job done the right way.
Thank you for working on this @carolinan! 👍
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
7 tasks
|
I'm not sure if the This change has introduced a regression, as the Term Description block now is not registered without an active Gutenberg plugin running. |
SiobhyB
pushed a commit
that referenced
this pull request
Oct 27, 2023
Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active.
SiobhyB
pushed a commit
that referenced
this pull request
Oct 27, 2023
Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active.
SiobhyB
pushed a commit
that referenced
this pull request
Oct 27, 2023
Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active.
SiobhyB
pushed a commit
that referenced
this pull request
Oct 28, 2023
* Patterns: set context of pattern category api call to view so authors and contributors can access (#55553) * Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539) * Update useContainsThirdPartyBlocks and texts * Improve texts a bit * Show the list of unsupported blocks * Use the BlockTitle component instead * Simplify modal text * Revert "Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539)" This reverts commit f2dd6de. * Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539) * Update useContainsThirdPartyBlocks and texts * Improve texts a bit * Show the list of unsupported blocks * Use the BlockTitle component instead * Simplify modal text * Revert CSS changes to show/hide embedded pdf (#55667) * Ensure Term Description block is available in core (#55669) Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active. --------- Co-authored-by: Glen Davies <[email protected]> Co-authored-by: David Arenas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The term description block displays the description of taxonomies in archives, and does not output anything on the front
if it is used in any other context.
Closes #38552
Why?
It can be confusing if you add a block to the post content, that is visible in the editor but not the front.
How?
Adds
__experimental": "fse", to block.jsonTesting Instructions
Create a new post using the block editor.
Try to add a term description block. Confirm that the block is not available.
Go to the Site Editor and edit any template.
Try to add a term description block. Confirm that the block is available.
(if you view the front, it still wont show unless you are on an archive page for a taxonomy that has a description to show)