Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Term Description block is registered in core #55669

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Ensure Term Description block is registered in core #55669

merged 1 commit into from
Oct 27, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Oct 27, 2023 •
edited
Loading

What?

With this PR, changes are made so that the Term Description block (core/term-description) is available in core without the need to install the Gutenberg plugin.

Why?

As per #55665, 6.4-RC2 saw a breaking change in which the Term Description block was no longer available within the full-site editor. This regression was introduced in #51053.

How?

Due to the urgency of this fix, this PR simply reverts #51053 so that the Term Description block is not completely broken without the Gutenberg plugin installed.

The original bug, in which the block is available in places it shouldn't be (i.e. the post editor), can be addressed separately to this PR. The thinking here is as follows:

  1. We're extremely tight on time, given we're late into Friday and the hope is to have 6.4 finalised on Monday.
  2. The original bug (Term Description block should only be available in the FSE template editor. #38552) wasn't a new regression and had been reproducible in core for over a year. There isn't an urgency to include a fix for it in 6.4 and we can address it separately.

Testing Instructions

  1. With a block theme, open Appearance → Editor.
  2. Open Templates → All Archives.
  3. Try to add the Term Description block, verify its availability within the inserter.

Testing Instructions for Keyboard

N/A

Ensure Term Description block is available in core
7bff62c 
Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active.
@SiobhyB SiobhyB added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention labels Oct 27, 2023
@SiobhyB SiobhyB marked this pull request as ready for review October 27, 2023 18:51
@SiobhyB SiobhyB mentioned this pull request Oct 27, 2023
Closed
@github-actions
Copy link

Flaky tests detected in 7bff62c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6671034389
📝 Reported issues:

luisherranz
luisherranz approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@luisherranz luisherranz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that reverting #51053 to solve the regression for WP 6.4, and address the original problem in a future PR instead, sounds like the best solution 🙂

@SiobhyB SiobhyB merged commit 8f3392b into trunk Oct 27, 2023
66 checks passed
@SiobhyB SiobhyB deleted the revert/term-description-availability branch October 27, 2023 19:46
@github-actions github-actions bot added this to the Gutenberg 17.0 milestone Oct 27, 2023
SiobhyB pushed a commit that referenced this pull request Oct 27, 2023
Ensure Term Description block is available in core (#55669)
fe0bbd8 
Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active.
@SiobhyB SiobhyB mentioned this pull request Oct 27, 2023
Merged
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Oct 27, 2023

Noting for posterity that this has been cherry-picked for inclusion in 6.4 in fe0bbd8, including as it fixes a breaking change that was introduced in 6.4.

@SiobhyB SiobhyB mentioned this pull request Oct 27, 2023
Open
SiobhyB pushed a commit that referenced this pull request Oct 28, 2023
@glendaviesnz @DAreRodz
Cherry-picked commits for WordPress 6.4 RC3 (#55583)
f28647d 
* Patterns: set context of pattern category api call to view so authors and contributors can access (#55553)

* Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539)

* Update useContainsThirdPartyBlocks and texts

* Improve texts a bit

* Show the list of unsupported blocks

* Use the BlockTitle component instead

* Simplify modal text

* Revert "Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539)"

This reverts commit f2dd6de.

* Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539)

* Update useContainsThirdPartyBlocks and texts

* Improve texts a bit

* Show the list of unsupported blocks

* Use the BlockTitle component instead

* Simplify modal text

* Revert CSS changes to show/hide embedded pdf (#55667)

* Ensure Term Description block is available in core (#55669)

Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active.

---------

Co-authored-by: Glen Davies <[email protected]>
Co-authored-by: David Arenas <[email protected]>
@hellofromtonya hellofromtonya mentioned this pull request Oct 29, 2023
Closed
@danieldudzic danieldudzic mentioned this pull request Oct 30, 2023
Closed
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Oct 31, 2023
@karmatosed
Update editor related npm packages for 6.4 RC3.
5dff923 
The npm packages needed update for 6.4 RC3.

Patch: #5587.
This PR includes the following changes:

- Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories].
- Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks].
- Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari].
- Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core]

Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw.

See #59411.


git-svn-id: https://develop.svn.wordpress.org/trunk@57034 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to WordPress/WordPress that referenced this pull request Oct 31, 2023
Update editor related npm packages for 6.4 RC3.
6edefe6 
The npm packages needed update for 6.4 RC3.

Patch: WordPress/wordpress-develop#5587.
This PR includes the following changes:

- Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories].
- Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks].
- Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari].
- Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core]

Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw.

See #59411.

Built from https://develop.svn.wordpress.org/trunk@57034


git-svn-id: http://core.svn.wordpress.org/trunk@56545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Oct 31, 2023
@karmatosed
Update editor related npm packages for 6.4 RC3.
4419e55 
The npm packages needed update for 6.4 RC3.

Patch: WordPress/wordpress-develop#5587.
This PR includes the following changes:

- Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories].
- Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks].
- Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari].
- Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core]

Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw.

See #59411.

Built from https://develop.svn.wordpress.org/trunk@57034


git-svn-id: https://core.svn.wordpress.org/trunk@56545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Oct 31, 2023
@karmatosed
Update editor related npm packages for 6.4 RC3.
5107a14 
The npm packages needed update for 6.4 RC3.

Patch: #5587
This PR includes the following changes:

- Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories].
- Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks].
- Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari].
- Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core]


Reviewed by helloFromTonya.
Merges [57034] to the 6.4 branch.

Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw.

See #59411.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57035 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Oct 31, 2023
Update editor related npm packages for 6.4 RC3.
751b6ac 
The npm packages needed update for 6.4 RC3.

Patch: WordPress/wordpress-develop#5587
This PR includes the following changes:

- Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories].
- Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks].
- Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari].
- Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core]


Reviewed by helloFromTonya.
Merges [57034] to the 6.4 branch.

Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw.

See #59411.

Built from https://develop.svn.wordpress.org/branches/6.4@57035


git-svn-id: http://core.svn.wordpress.org/branches/6.4@56546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisherranz luisherranz luisherranz approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

@ockham ockham Awaiting requested review from ockham

@aristath aristath Awaiting requested review from aristath

@carolinan carolinan Awaiting requested review from carolinan

@mikachan mikachan Awaiting requested review from mikachan

@karmatosed karmatosed Awaiting requested review from karmatosed

@annezazu annezazu Awaiting requested review from annezazu

@bph bph Awaiting requested review from bph

@hellofromtonya hellofromtonya Awaiting requested review from hellofromtonya

Assignees
No one assigned
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SiobhyB @luisherranz