-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick PRs for the WordPress 6.1.1 RC #45706
Commits on Nov 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 19358d7 - Browse repository at this point
Copy the full SHA 19358d7View commit details -
Fluid typography: add font size constraints (#44993)
* Initial commit: - Adds default minimum font size limits so that text does not become smaller than 14px/0.875rem/0.875em. The consequence will be that all fluid font sizes will be no smaller than 14px/0.875rem/0.875em in any viewport width. - Users may define font-sizes that are smaller than 14px/0.875rem/0.875em. In this case the user-defined font size becomes the minimum. For example if a user defines 9px for a block, then the minimum font size for that block will be 9px. - Min font size should not be greater than max font size. - Round to 3 decimal places (JS) - Rounding computed min and max values * Rounding parsed min and max values * Updating JS rounding function so that values are rounded * Removing type coercion * Updating failing test * Remove reference to preset in favour of "fontSize" * Ensure that rem units are used when calculating min and max boundaries in em This is to keep it consistent with the original formula and ensure the fluid argument in clamp is working off a size relative to :root Fixing formatting and grammar Rolling back renaming $preset to $font_size in preference to a follow up. Do not clamp value if there is no min size and the font size is less than 14px * Oh Linter! You persistent crank. * For font sizes of < 14px that have no defined minimum sizes, use the font size to set the floor of the clamp() value. * Removing max < min check. It wasn't there before. It can be a follow up if required as it requires extra logic. * Checking for a zero-based linear factor. If we find one, default to `1` * Refer to correct JS var in JS file
Configuration menu - View commit details
-
Copy full SHA for cfe41d8 - Browse repository at this point
Copy the full SHA cfe41d8View commit details -
Allow direct selection of nested Page List block by avoiding dual ren…
…dering within block (#45143) * Fix dual rendering within Page List * refactor the content of the block to a function Co-authored-by: Ben Dwyer <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c1d0fb8 - Browse repository at this point
Copy the full SHA c1d0fb8View commit details -
Fix popover deprecations (#45195)
* Fix popover deprecations * Also remove from docs and types * Update changelog * Update packages/components/CHANGELOG.md Co-authored-by: Marco Ciampini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 27fc28f - Browse repository at this point
Copy the full SHA 27fc28fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1e989b - Browse repository at this point
Copy the full SHA d1e989bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7c87a9 - Browse repository at this point
Copy the full SHA b7c87a9View commit details -
Convert the
ColorPalette
component to TypeScript (#44632)* Convert the ColorPalette component to TypeScript There are some ts-ignore statements that would be good to remove. * Correct the PR number in the CHANGELOG * Apply Marco's suggestion to remove ts-ignore comments Destructure props int constants after the function signature, not inside it. * Replace complex type with ReactNode, thanks to Marco's suggestion * Apply Marco's suggestions for TS verbatim #44632 (review) * Prevent an error from colors possibly being undefined Types of property 'colors' are incompatible. Type 'Colors | undefined' is not assignable to type '(Color | MultipleColors)[]'. Type 'undefined' is not assignable to type '(Color | MultipleColors)[]'. * Rename Color and MultipleColors to ColorObject and PaletteObject * Alphabetize the imports again * Remove another needless ts-ignore comment * Revert "Prevent an error from colors possibly being undefined" This reverts commit 7fe648e. * Make colors allow undefined * Make actions optional, which I forgot before * Commit Marco's changes, including a named export * Add default tags, thanks to Marco's idea * Apply Marco's suggestion to remove ts-ignore Add 'as CSSProperties' to remove the need for ts-ignore * Apply Marco's suggestions, creating UnforwardedColorProps The jsx example might not be right. Also, I added a description for the component in the JS DocBlock, as there wasn't one in README.md. But maybe that's not right. * Fix a linting error, remove needless className * Commit Marco's suggestion: Update packages/components/src/color-palette/stories/index.tsx Co-authored-by: Marco Ciampini <[email protected]> * Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts Co-authored-by: Marco Ciampini <[email protected]> * Rename test/index.js to test/indes.tsx, mv snapshot * Add types to test/index.tsx * Renamce styles.js to styles.ts * Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts Co-authored-by: Marco Ciampini <[email protected]> * Revert "Add types to test/index.tsx" This reverts commit 06f7c4e. * Paste Marco's description verbatim #44632 (review) * Copy props verbatim from types.ts into README.md * Update the JSDoc description to be the same as the README.md description The usage example was already the same as in the README.md * Remove extra entry for Tooltip I think I added this when merging in trunk and resolving the conflicts. * Move the CHANGELOG entry up, to Unreleased * Move Usage section to the top of the README. remove experimental props from README * Commit Marco's suggestion: Update packages/components/src/color-palette/README.md Co-authored-by: Marco Ciampini <[email protected]> * Remove the example of the full props * Change the props format to match CONTRIBUTING.md https://github.com/WordPress/gutenberg/blob/a42805e157f6c6933f4ef7cabcfc87fa3af81aea/packages/components/CONTRIBUTING.md#readme-example * Commit Marco's suggestion: Update packages/components/src/color-palette/stories/index.tsx Co-authored-by: Marco Ciampini <[email protected]> * Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts Co-authored-by: Marco Ciampini <[email protected]> * Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts Co-authored-by: Marco Ciampini <[email protected]> * Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts Co-authored-by: Marco Ciampini <[email protected]> Co-authored-by: Marco Ciampini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a69ad93 - Browse repository at this point
Copy the full SHA a69ad93View commit details -
List v2: fix migration when nested list is invalid (#44822)
* List v2: fix migration when nested list is invalid * Reduce test case
Configuration menu - View commit details
-
Copy full SHA for 1d6e86f - Browse repository at this point
Copy the full SHA 1d6e86fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5df9d42 - Browse repository at this point
Copy the full SHA 5df9d42View commit details -
Table Block: Apply borders and padding on both front end and editor (#…
…45069) * Apply table borders on front end * Apply default cell padding to editor and front end * Remove padding and border from theme.scss
Configuration menu - View commit details
-
Copy full SHA for 86755ae - Browse repository at this point
Copy the full SHA 86755aeView commit details -
Change the order of the pseudo-states in the pseudo selectors array (#…
…45559) * Move visited to start of array Co-Authored-By: Stephen A. Bernhardt <[email protected]> * Add comment Co-authored-by: Stephen A. Bernhardt <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2406bb9 - Browse repository at this point
Copy the full SHA 2406bb9View commit details -
Do not look for block variants, if not supporting block-templates (#4…
…5362) * Do not look for block varients, if not supporting block-templates * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Aki Hamano <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 78717bd - Browse repository at this point
Copy the full SHA 78717bdView commit details -
Restore the empty paragraph inserter (#45542)
* Restore the empty paragraph inserter * Try fixing failing e2e tests * Fix pointer events Co-authored-by: George Mamadashvili <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bcff52e - Browse repository at this point
Copy the full SHA bcff52eView commit details -
Cover: Avoid content loss when the templateLock value is all or conte…
…ntOnly (#45632) * Cover: Avoid content loss when the templateLock value is all or contentOnly * Add inline comment
Configuration menu - View commit details
-
Copy full SHA for d6485c6 - Browse repository at this point
Copy the full SHA d6485c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 035afba - Browse repository at this point
Copy the full SHA 035afbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6941ad1 - Browse repository at this point
Copy the full SHA 6941ad1View commit details -
Switch background color to text color on block separator (#44943)
* Switch background to text, remove gradients on separator block * Use theme_json class to fix separator color issue * Add fix for the editor * Fix the separator on the editor * Give the border color more specifity * Add text color specifity * Small refactor * Add unit test for separator background php part * Use only color instead of border-color * Refactor to just update declarations * Update documentation * Add static to private function * Update the wording of the comments * Add missing spread to global styles output * Rename test to fit the new function Co-authored-by: Michal Czaplinski <[email protected]> Co-authored-by: Andrew Serong <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 67b7b5e - Browse repository at this point
Copy the full SHA 67b7b5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b4797b - Browse repository at this point
Copy the full SHA 3b4797bView commit details