List v2: fix migration when nested list is invalid #44822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: +1.69 kB (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
ellatrix
added
the
Backport to WP 6.7 Beta/RC
|
👋 Hi there! Is this intended to be merged before the RC2 tomorrow? |
|
This should be merged, yes, but needs a review. |
|
The fix is not working in my environment :-( Gutenberg: Version 14.4.0-rc.1 I'm using Screen.Recording.2022-10-24.at.17.27.44.mov |
|
@c4rl0sbr4v0 I tried your HTML and it's working fine? Note that this PR will not fix list blocks if they're already migrated. Only unmigrated blocks. So create a new post with your content to test the PR. |
mcsf
approved these changes
Oct 28, 2022
|
As this is being discussed for backport to WordPress 6.1.1 or as a possible RC6 candidate, here is an additional report confirming reproduction in 6.1-RC5 and patch efficacy: Reproduction ReportEnvironment
Actual Results
Patch Test ReportEnvironment
Actual Results
Supplemental Artifacts
|
Mamaduka
added
Backport to WP Minor Release
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
* List v2: fix migration when nested list is invalid * Reduce test case
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
* List v2: fix migration when nested list is invalid * Reduce test case
Mamaduka
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This should fix #44757. The problem with this list is that there's multiple nested lists inside one list item, which is (for us) invalid. Thankfully we have existing code that takes care of this in the raw handler, but we're not making use of it. This PR changes list migration so that it now runs through the raw handler, which fixes the lists.
How?
Use the
rawHandler.Testing Instructions
See #44757 and added test.
Screenshots or screencast