Link to homeUrl from site editor view menu. #45475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
peterwilsoncc
commented
Nov 2, 2022
Comment on lines
+69
to
+72
| const { | ||
| getUnstableBase, // Site index. | ||
| } = select( coreStore ); | ||
|
|
There was a problem hiding this comment.
This is a 100% copy-paste from packages/block-library/src/home-link/edit.js -- let me know if there is a better way. I am sure there is.
|
Size Change: +15 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Mamaduka
added
[Type] Bug
Mamaduka
approved these changes
Nov 2, 2022
| blockEditorMode: __unstableGetEditorMode(), | ||
| homeUrl: getUnstableBase()?.home, |
There was a problem hiding this comment.
This is much better. We were only using the URL setting, so there was no need to return the whole object.
|
@peterwilsoncc, the #45476 solved the issue for the Site Logo block. We still need to resolve this for the "View" URL. |
Mamaduka
added
the
Backport to WP Minor Release
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
Mamaduka
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces the siteURL link in the full site editor view menu with the homeUrl.
Why?
siteUrl is a reference to the WordPress install, ie the folder containing wp-cron.php, wp-mail.php, etc. homeUrl is the home page of the website. On sites with WordPress installed in a sub-directory, the two values can differ.
How?
I've added
@wordpress/core-dataas a dependency of the site editor header and used that to locate the homeUrl. I suspect it could be added equally well the the existing settings but I was unsure how to go about that.Fixes #45474.
Testing Instructions
This should open the site's home page rather than the sub-directory containing the install/
Screenshots or screencast