Cherry-pick PRs for the WordPress 6.1.1 RC #45706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit: - Adds default minimum font size limits so that text does not become smaller than 14px/0.875rem/0.875em. The consequence will be that all fluid font sizes will be no smaller than 14px/0.875rem/0.875em in any viewport width. - Users may define font-sizes that are smaller than 14px/0.875rem/0.875em. In this case the user-defined font size becomes the minimum. For example if a user defines 9px for a block, then the minimum font size for that block will be 9px. - Min font size should not be greater than max font size. - Round to 3 decimal places (JS) - Rounding computed min and max values * Rounding parsed min and max values * Updating JS rounding function so that values are rounded * Removing type coercion * Updating failing test * Remove reference to preset in favour of "fontSize" * Ensure that rem units are used when calculating min and max boundaries in em This is to keep it consistent with the original formula and ensure the fluid argument in clamp is working off a size relative to :root Fixing formatting and grammar Rolling back renaming $preset to $font_size in preference to a follow up. Do not clamp value if there is no min size and the font size is less than 14px * Oh Linter! You persistent crank. * For font sizes of < 14px that have no defined minimum sizes, use the font size to set the floor of the clamp() value. * Removing max < min check. It wasn't there before. It can be a follow up if required as it requires extra logic. * Checking for a zero-based linear factor. If we find one, default to `1` * Refer to correct JS var in JS file
…dering within block (#45143) * Fix dual rendering within Page List * refactor the content of the block to a function Co-authored-by: Ben Dwyer <[email protected]>
* Fix popover deprecations * Also remove from docs and types * Update changelog * Update packages/components/CHANGELOG.md Co-authored-by: Marco Ciampini <[email protected]>
* Convert the ColorPalette component to TypeScript
There are some ts-ignore statements
that would be good to remove.
* Correct the PR number in the CHANGELOG
* Apply Marco's suggestion to remove ts-ignore comments
Destructure props int constants after the function
signature, not inside it.
* Replace complex type with ReactNode, thanks to Marco's suggestion
* Apply Marco's suggestions for TS verbatim
#44632 (review)
* Prevent an error from colors possibly being undefined
Types of property 'colors' are incompatible.
Type 'Colors | undefined' is not assignable to type '(Color | MultipleColors)[]'.
Type 'undefined' is not assignable to type '(Color | MultipleColors)[]'.
* Rename Color and MultipleColors to ColorObject and PaletteObject
* Alphabetize the imports again
* Remove another needless ts-ignore comment
* Revert "Prevent an error from colors possibly being undefined"
This reverts commit 7fe648e.
* Make colors allow undefined
* Make actions optional, which I forgot before
* Commit Marco's changes, including a named export
* Add default tags, thanks to Marco's idea
* Apply Marco's suggestion to remove ts-ignore
Add 'as CSSProperties'
to remove the need for ts-ignore
* Apply Marco's suggestions, creating UnforwardedColorProps
The jsx example might not be right.
Also, I added a description for the component
in the JS DocBlock, as there wasn't one in README.md.
But maybe that's not right.
* Fix a linting error, remove needless className
* Commit Marco's suggestion: Update packages/components/src/color-palette/stories/index.tsx
Co-authored-by: Marco Ciampini <[email protected]>
* Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts
Co-authored-by: Marco Ciampini <[email protected]>
* Rename test/index.js to test/indes.tsx, mv snapshot
* Add types to test/index.tsx
* Renamce styles.js to styles.ts
* Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts
Co-authored-by: Marco Ciampini <[email protected]>
* Revert "Add types to test/index.tsx"
This reverts commit 06f7c4e.
* Paste Marco's description verbatim
#44632 (review)
* Copy props verbatim from types.ts into README.md
* Update the JSDoc description to be the same as the README.md description
The usage example was already the same
as in the README.md
* Remove extra entry for Tooltip
I think I added this
when merging in trunk and resolving the conflicts.
* Move the CHANGELOG entry up, to Unreleased
* Move Usage section to the top of the README. remove experimental props from README
* Commit Marco's suggestion: Update packages/components/src/color-palette/README.md
Co-authored-by: Marco Ciampini <[email protected]>
* Remove the example of the full props
* Change the props format to match CONTRIBUTING.md
https://github.com/WordPress/gutenberg/blob/a42805e157f6c6933f4ef7cabcfc87fa3af81aea/packages/components/CONTRIBUTING.md#readme-example
* Commit Marco's suggestion: Update packages/components/src/color-palette/stories/index.tsx
Co-authored-by: Marco Ciampini <[email protected]>
* Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts
Co-authored-by: Marco Ciampini <[email protected]>
* Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts
Co-authored-by: Marco Ciampini <[email protected]>
* Commit Marco's suggestion: Update packages/components/src/color-palette/types.ts
Co-authored-by: Marco Ciampini <[email protected]>
Co-authored-by: Marco Ciampini <[email protected]>
* List v2: fix migration when nested list is invalid * Reduce test case
…45069) * Apply table borders on front end * Apply default cell padding to editor and front end * Remove padding and border from theme.scss
…45559) * Move visited to start of array Co-Authored-By: Stephen A. Bernhardt <[email protected]> * Add comment Co-authored-by: Stephen A. Bernhardt <[email protected]>
…5362) * Do not look for block varients, if not supporting block-templates * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Aki Hamano <[email protected]>
* Restore the empty paragraph inserter * Try fixing failing e2e tests * Fix pointer events Co-authored-by: George Mamadashvili <[email protected]>
…ntOnly (#45632) * Cover: Avoid content loss when the templateLock value is all or contentOnly * Add inline comment
Mamaduka
requested review from
spacedmonkey,
ajitbohra,
ellatrix and
tellthemachines
as code owners
|
|
Mamaduka
removed request for
spacedmonkey,
ajitbohra,
ellatrix and
tellthemachines
|
Size Change: +704 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
Mamaduka
changed the title
* Switch background to text, remove gradients on separator block * Use theme_json class to fix separator color issue * Add fix for the editor * Fix the separator on the editor * Give the border color more specifity * Add text color specifity * Small refactor * Add unit test for separator background php part * Use only color instead of border-color * Refactor to just update declarations * Update documentation * Add static to private function * Update the wording of the comments * Add missing spread to global styles output * Rename test to fit the new function Co-authored-by: Michal Czaplinski <[email protected]> Co-authored-by: Andrew Serong <[email protected]>
Mamaduka
force-pushed
the
backport/wp-611-release
branch
from
04636b0
to
3b4797b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked PRs:
ColorPalettetests to@testing-library/react#44108ColorPalettecomponent to TypeScript #44632