Paf 49 test cert 2 #112
Open
Paf 49 test cert 2 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHoldergov
requested review from
shamiluwais,
sulthan-ahmed,
jamiecarterHO and
adityababumallisettiHO
|
can’t approve til it’s tested |
| @@ -184,4 +190,4 @@ spec: | |||
| runAsNonRoot: true | |||
| volumes: | |||
| - name: public | |||
| emptyDir: {} | |||
| emptyDir: {} | |||
|
Just fixed your PR, the headings weren't showing. You had your backtiks in the wrong place |
apps/paf/models/file-upload.js
Outdated
| @@ -1,4 +1,3 @@ | |||
| /* eslint-disable node/no-deprecated-api */ | |||
There was a problem hiding this comment.
is there a reason why node/no-deprecated-api */ this was removed?
there is a new repo about the API documentation
* We will kube exec in and try to run the commands via Node REPL
update image
rebasing the branch
- Add element ids to side-nav html - Set current url and class list for navigation sections in assets/js/index.js - Add css styling for highlighting navigation sections in assets/css/app.scss Co-authored-by: muthrajan <[email protected]>
…try textbox. (#96) * PAF-128 & PAF-129 Added validation for phone and country textbox [PAF- 129](https://collaboration.homeoffice.gov.uk/jira/browse/PAF-129) All 'Country' fields allow any text without the use of drop down list [PAF-128](https://collaboration.homeoffice.gov.uk/jira/browse/PAF-128 URL's are being accepted in all free text fields - added validation rules to all countries fields in field/index.js - added dependent property to avoid error message when yes is selected on another location Tested manually * add behaviour to unset values
* PAF-61 Update ims-resolver deployment to use branch image * Deploy with image containing PAF-61 changes * Update resolver configmap to use correct value * Add Keycloak variables to ims resolver deployment env from secret * PAF-61 Update resolver image to latest for ticket.
* Add missing deploys to delete * Alter get pr branch command to be more like other new repos
JHoldergov
force-pushed
the
PAF-49-test-cert-2
branch
from
51fa1a4
to
fafb9e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
To access PRP1 we have to access the link via a secure way. So we have a self-signing certificate provided.
Why?
This is the most secure way for the services to talk to each other, we have set the NODE_AUTH=0 because as a self signing cert it does not have a recognised authority hence why we keep the following in the ims reolver deployment
We will need to add prod option in there.
How?
So the best way for Node is to mount a config map as a persistent storage to store the cert then mount the config map as a volume in/etc/ss/certs and call it in the PAF app.
Testing?
@shamiluwais had a look and will do some further verification that everything is as it is as we are currently facing a 504 and the logs are attached below
Screenshots (optional)
Anything Else? (optional)
We are waiting for the error 504 to be resolved and then we can test but prior to this we did have a case id
Screenshots (optional)
Anything Else? (optional)
let me know if you need anything - so as for the cert we have it stored securely in hof-services config as a base64 encoded cert and called it via the deploy.sh script