Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAF 166:Highlight sections on menu navigation #95

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

Rhodine-orleans-lindsay
Copy link
Contributor

What?

Highlight sections on menu navigation - PAF-166

Why?

  • When a user is on a question page within a given section the section should be highlighted in the menu

How?

  • Add element ids to side-nav html
  • Set current url and class list for navigation sections in assets/js/index.js
  • Add css styling for highlighting navigation sections in assets/css/app.scss

Testing?

  • tests passing locally

Screenshots (optional)

Anything Else? (optional)

- Add element ids to side-nav html
- Set current url and class list for navigation sections in assets/js/index.js
- Add css styling for highlighting navigation sections in assets/css/app.scss
@muthrajan
Copy link
Contributor

All are OK. Approved

@muthrajan muthrajan self-requested a review January 16, 2024 17:03
Copy link
Contributor

@muthrajan muthrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@muthrajan muthrajan merged commit abfac19 into master Jan 25, 2024
2 of 3 checks passed
@muthrajan muthrajan deleted the navigation-menu branch January 25, 2024 10:27
JHoldergov pushed a commit that referenced this pull request Feb 1, 2024
- Add element ids to side-nav html
- Set current url and class list for navigation sections in assets/js/index.js
- Add css styling for highlighting navigation sections in assets/css/app.scss

Co-authored-by: muthrajan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants