Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discrepancies between fv URLs across deployments and ingress (UAT/STG/PROD) #122

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jamiecarterHO
Copy link
Contributor

What?

Edited references to FILE_VAULT_URL across deployments for PAF app and file-vault so that they all use the same URL
Also updated the file-vault ingress file so that the format matches other contemporary forms.

Why?

QAT team were unable to retrieve uploaded files in the UAT environment due to a mismatch of URLs causing incorrect redirection from filevault login, or incorrect logging of retrieval URLs causing a page not found error.

How?

Updated conditional variable declaration in deployment and ingress files.

Testing?

This will not be possible to test until it has reached UAT environment.

Copy link
Contributor

@shamiluwais shamiluwais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiecarterHO jamiecarterHO merged commit ce4244b into master Jan 22, 2024
2 of 3 checks passed
@jamiecarterHO jamiecarterHO deleted the fix-fv-url-config-mismatch branch January 22, 2024 15:53
JHoldergov pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants