Fix weekly branch environment teardown and PR merge branch teardown #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing deploys to delete * Alter get pr branch command to be more like other new repos
you can run this one after 5pm to ensure it tears everything, I saw permissions errors before |
JHoldergov
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Add missing deploys to delete * Alter get pr branch command to be more like other new repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updated config to tear down PR envs
Why?
The drone/cron jobs that should tear down branch environment deployments when a) the accompanying PR is merged to master or b) weekly at the end of the week is currently not succeeding.
This appears to be because of older config not correctly calling the branches or cron jobs.
How?
deploy.shsection to include all microservices deployed by PAF in the relevant delete commandCopied new config/alterations from IMA and ASC projects where the jobs appear to work ok.
Anything Else?
The drone cron job in the PAF project (drone/paf/settings/cron is currently misnamed as
tear_down_envsand so it doesn't run any specific step from thedrone.yml. After these changes we need to create a new cron job calledtear_down_pr_envswith (ideally) the schedule0 0 21 * * 5(but stock 'weekly' would be ok)