-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel Support For STM32 MCU's #985
Bazel Support For STM32 MCU's #985
Conversation
- created a bazel toolchain with both `clang` and `arm-none-eabi-gcc` - created a demo project for compiling firmware for `frankie_v1` (naming and restructuring of firmware can wait for another PR I think) - added a script for writing the built firmware to the demo board and debugging it with gdb - added a script to convert clangs code coverage results into something codecov can understand
@MathewMacDougall @jonathanlew - the main thing to review here is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the codecov? https://codecov.io/gh/UBC-Thunderbots/Software/tree/3767f2fbf361ef41438b4f3db2ada6e06350b719/src/software Why isn't it showing up in the PR?
I was waiting to see if it showed up, gonna open one more totally clean PR which should get it.......... |
sigh looks like codecov got knackered somehow. I've seen similar issues before when there is odd stuff happening between |
Other things to note about coverage:
Both of these are definitely regressions, and I am extremely unhappy about that. However I really don't think we can do much better, and code coverage should still serve as a good indicator where we need to improve. We're waiting for bazel to get their stuff together, there are several tickets open right now, and the resolution of any of them should clear things up. |
After offline discussion with Mat, we've agreed that the ideal would be to redo the toolchain for a version of gcc that bazel supports for coverage (see this issue: bazelbuild/bazel#7719), but we need to get this in ASAP to unblock elec, and it's functional, so it will have to do for now. |
Please fill out the following before requesting review on this PR
Description
Opening this PR because I'm pretty sure I totally broke codecov with #937.
clang
andarm-none-eabi-gcc
frankie_v1
(naming and restructuring of firmware can wait for another PR I think)Testing Done
Please fill out the following before requesting review on this PR
Description
Opening this PR because I'm pretty sure I totally broke codecov with #937.
clang
andarm-none-eabi-gcc
frankie_v1
(naming and restructuring of firmware can wait for another PR I think)Testing Done
Code can build, and be flash and debugged on the stm23h7 demo board
Resolved Issues
Length Justification
Toolchain is massive, demo project is pretty massive (but should require minimal review).
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.h
file) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom
. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.