-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel Support For stm32 MCU's - Take 2 #981
Closed
garethellis0
wants to merge
72
commits into
UBC-Thunderbots:master
from
garethellis0:bazel-firmware-stm32-rule-take-2
Closed
Bazel Support For stm32 MCU's - Take 2 #981
garethellis0
wants to merge
72
commits into
UBC-Thunderbots:master
from
garethellis0:bazel-firmware-stm32-rule-take-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
==========================================
+ Coverage 67.24% 77.4% +10.16%
==========================================
Files 263 314 +51
Lines 6872 19222 +12350
==========================================
+ Hits 4621 14879 +10258
- Misses 2251 4343 +2092
Continue to review full report at Codecov.
|
Closing in favor of #985 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Opening this PR because I'm pretty sure I totally broke codecov with #937.
clang
andarm-none-eabi-gcc
frankie_v1
(naming and restructuring of firmware can wait for another PR I think)Testing Done
Code can build, and be flash and debugged on the stm23h7 demo board
Resolved Issues
Length Justification
Toolchain is massive, demo project is pretty massive (but should require minimal review).
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.h
file) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom
. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO
(or similar) statements should either be completed or associated with a github issue