Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel Support For stm32 MCU's - Take 2 #981

Conversation

garethellis0
Copy link
Contributor

Please fill out the following before requesting review on this PR

Description

Opening this PR because I'm pretty sure I totally broke codecov with #937.

  • created a bazel toolchain with both clang and arm-none-eabi-gcc
  • created a demo project for compiling firmware for frankie_v1 (naming and restructuring of firmware can wait for another PR I think)
  • added a script for writing the built firmware to the demo board and debugging it with gdb
  • added a script to convert clangs code coverage results into something codecov can understand

Testing Done

Code can build, and be flash and debugged on the stm23h7 demo board

Resolved Issues

Length Justification

Toolchain is massive, demo project is pretty massive (but should require minimal review).

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue
  • Justify drops in code coverage: If this PR results in a non-trivial drop in code coverage (a bot should post a coverage diagram as a comment), please justify why we can't test the code that's not covered.

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #981 into master will increase coverage by 10.16%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #981       +/-   ##
==========================================
+ Coverage   67.24%   77.4%   +10.16%     
==========================================
  Files         263     314       +51     
  Lines        6872   19222    +12350     
==========================================
+ Hits         4621   14879    +10258     
- Misses       2251    4343     +2092
Impacted Files Coverage Δ
src/software/util/time/duration.cpp 100% <ø> (ø) ⬆️
src/software/ai/hl/stp/stp_test.cpp 97.87% <100%> (ø)
.../backend/input/network/filter/ball_filter_test.cpp 99.36% <50%> (ø)
src/software/geom/circle.h 20% <0%> (-80%) ⬇️
src/software/geom/ray.h 37.5% <0%> (-62.5%) ⬇️
src/software/geom/line.h 50% <0%> (-50%) ⬇️
src/software/geom/voronoi_diagram.h 50% <0%> (-50%) ⬇️
src/software/ai/ai.cpp 0% <0%> (-30.77%) ⬇️
src/software/world/refbox_constants.cpp 54.54% <0%> (-28.79%) ⬇️
src/software/geom/segment.h 71.42% <0%> (-28.58%) ⬇️
... and 387 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f8f13...2e5f36a. Read the comment docs.

@garethellis0
Copy link
Contributor Author

Closing in favor of #985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant