Skip to content

Conversation

@TinaHu1
Copy link
Owner

@TinaHu1 TinaHu1 commented Oct 10, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

arolshan and others added 30 commits September 5, 2019 12:21
* add swaggers

* add search examples

* Update readme.md

* Update QueryPackQueries_API.json

* resourceName to queryPackName

* Update QueryPackQueries_API.json

* update null to null

* add to examples

* add nullable and remove etag

* fix validation issues

* Update QueryPacks_API.json

* better naming

* more fixes

* fix json

* add 203 example

* fix update tags example

* fix validation

* Update QueryPackQueries_API.json

* Update QueryPackQueriesSearch.json

* fix validations

* Update QueryPackQueries_API.json

* Update QueryPackQueries_API.json

* fixes after review

* fixes after code review

* naming and mismatch
Add change feed properties to Storage Blob Services.
* ANF-169 add 2019-07-01 swagger

Initial checkin is with the base 2019-06-01 swagger.

* ANF-169 add 2019-07-01 swagger

* ANF-169 add 2019-07-01 API version

* Update netapp.json
#6964)

* Billing RP spec changes for listInvoiceSectionsWithCreateSubscriptionPermission API

* Updated the operation id

* Added x-ms-pageable

* Added next link

* Deleted unused file ProductCancelByBillingAccount

* Incorporated review comments

Incorporated review comments
* add Java readme for resources

* move Java section to readme.java.md

* Resources: update readme.java.md file

* Resources: update readme.java.md file

* Resources: update args in readme.java.md
* Add version 2018-06-preview version to readme.go

* Quick fix
* Add VMScaleSet ScaleIn Policy

Adds VMScaleSet ScaleIn policy that is supported with the 2019-03-01 header but not included in Swagger

* Update compute.json

Fix whitespacing

* Update compute.json

Fix whitespace

* Update compute.json

Fix indentation

* Fix indentation

Fix indentation
…7047)

* Set IoTSecuritySolutions & IoTSecuritySolutionAnalytics API as stable

* Set IoTSecuritySolutions & IoTSecuritySolutionAnalytics API as stable

* remove example from file names

* remove paging support from IoTSecurityDeviceRecommendationsList

* remove paging from IoTSecurityAlertedDevicesList

* SecuritySolution documentation updates

* Fix operations naming

* move devicesecuritygrups to stabe

* Change in analytic from IoT to Iot

* 4. Separate the aggregated alerts and recommendation operation to another swagger

* Improve documentation sections

* Security solution - set tags to HTTP verb

* Security solution - changed tags to IotSecuritySolution

* Revert "Security solution - changed tags to IotSecuritySolution"

This reverts commit 6dffac6.

* Revert "Security solution - set tags to HTTP verb"

This reverts commit ba76ba6.

* fix documentation

* fix syntax

* Update specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotSecuritySolutionAnalytics.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotSecuritySolutionAnalytics.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotSecuritySolutionAnalytics.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotSecuritySolutions.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotSecuritySolutions.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotSecuritySolutions.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotSecuritySolutionAnalytics.json

Co-Authored-By: Nick Schonning <[email protected]>

* solution/solutions inconsistency

* Nested properties in PATCH api swagger

* In PATCH, specify 'properties' field

* Updated PUT operation name to CreateOrUpdate

* Simplify array definition of analytics model

* fix spaces

* remove duplicate inheritence of CustomAlertRule

* fix example validation error

* fix ruleType Enum

* Adds suppression to readme
For releasing ScopeMap and Token features, we need to retrieve models from the scopemap spec file. 
The existing SDK version doesn't incorporate changes from the scopemap spec file. 

Requesting a new SDK build. Please suggest changes if deemed necessary.
shalinved and others added 29 commits October 8, 2019 11:10
…ion preview/2018-11-01-preview (#7352)

* Added modern subscription creation under billing profile and for CSP.

* SubscriptionFactory to Subscriptions.

* customerId to customerName.

* updated the CSP sub creation example.

* Corrected the createSubscriptionUnderBillingProfile example with correct profile name.
* Introduce new Api version 2019-08-01

* Fix issue in readme.md

* Fix issues with examples

* Fix DomainRegistration RP examples

* Fix missing package tags

* Address PR comments on spelling issues

* Add property EndpointDetail.InAccessible

* Remove deprecated metrics API

* Add custom words

* Fix Avacado errors

* Fix issues with Diagnostics API examples

* Remove error codes from swagger for Renew

* Fix more Diagnostics issues

* Remove Kudu Api with spelling issue.

* Remove property with spelling issue only

* Fix the readme file. Fix conflict on ManagedServiceIdentityType enum

* Add packages for API version for different languages
…ase for Postgres and MySQL (#6701)

* Swagger update to include Azure Active Directory Api for PG and MySQL

* Active directory administrator changes for ORCA preivew swagger

* AAD intergration Swagger changes for PostgreSQL and MySQL

* Azure Active Directory Intergration for PostgreSQL and MySQL

* Swagger Exmples update to include Azure Active Directory Api for PG and MySQL

* Fix Vnet Firewall rule model examples

* Fixing vnet firewall rulle examples

* Address review comments

* Address review comments
* Add Switch activity to public swagger.

* Update public swagger for Switch activity.

* Correct spelling issue.

* Add description to SwitchCase.
* Add alert top 10 devices information

* fix errors

* fix errors

* fix errors

* fix errors

* fix array error

* fix time field

* fix time field
* Update OracleAzureDbPostgreSqlSyncTask.json

Added "caseManipulation" to MigrateOracleAzureDbPostgreSqlSyncDatabaseInput object

* Fixing incorrect output of the CheckOCIDriver task.
* Azure Backup Version 2019-05-13  addition

New api version 2019-05-13 for ProtectedItems_Get,ProtectedItems_CreateOrUpdate,RecoveryPoints_List,RecoveryPoints_Get,Restores_Trigger, BackupJobs_List, BackupProtectedItems_List and version 2017-07-01 for ProtectionPolicies_CreateOrUpdate

* Update bms.json

Fixing inconsistent description for recoverytype across workloads

* Fixing description for recoveryType enum

* Fixing Lintdiff and spell check failures

* Lintdiff fix

* Lintdiff another fix

* another of lintdiff fix

* Another one of never ending lintdiff failures

Can we have tool to run this privately over the changes or can we have all the breaking changes in single go rather than one by one?

* Another of lintdiff failure fix

Getting them one by one and fixing them one by one

* Lintdiff failure one by one

* Litdiff another one  of failure

* Lintdiff Failure fix

* Removing redundant models across api versions

* Fixing redundant models

* Semantics failure fix

* Lintdiff Failure fix

* Semantic failure fix

* Semantics Failure fix

* Camel casing failure

* Update bms.json

Adding azure vm workload policy back and copying IaaSVMRestoreRequest to 2017-07-01

* Updating examples

* Pasting auto generated json specs

* Fixing spelling mistakes and an unintended change

* Moving examples to right folders

* Fixing recovery point inconsistency

* Removing ASE contracts

* Fixing alongwith spelling mistake

* Incorporating PR comments

* Moving Get and Patch on vaultconfig to version 2019-05-13

Moving Patch and Get of vault config to 2019-05-13

* Taken care of Ryan's pending comments

* Fixing validation errors

* Updating vault config feature flag name

* Taken care of Ryan's comment

Policy comment is still pending

* Moved all policy actions to 2019-05-13 version

* Moving Settings and sorting models in alphabatical order

* Mark additionalDetail as readonly
@TinaHu1 TinaHu1 merged commit c73e021 into TinaHu1:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.